1358991 - Compact Dark theme broken after restart

Status: RESOLVED WONTFIX

(WebExtensions :: General, defect)

Description

[Stijn Herreman]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170413192749

Steps to reproduce:

I've upgraded to Firefox 53, applied the new Compact Dark theme, and removed the 'Developer Edition theme enabler' addon.

I can go through the following steps to fix and reproduce the issue:
1. Enable the Default theme.
2. Restart the browser.
3. Enable the Compact Dark theme. The theme is working correctly.
4. Restart the browser. The theme is now a mix of the Compact Dark theme and Default theme. Switching between themes does not fix the issue, you need to go through the above steps again.


Actual results:

After restarting the browser, the theme seems to be a mix of the default theme and the Compact Dark theme. See the attachments.


Expected results:

The Compact Dark theme should still be fully applied.

Comment 1

[Stijn Herreman]

Attachment: before restart.PNG

Comment 2

[Stijn Herreman]

Attachment: after restart.PNG

Comment 3

[:Gijs (he/him)]

Does this reproduce without your add-ons installed (ie on an otherwise clean profile) ? Have you tried selectively disabling them to figure out the culprit?

Comment 4

[Stijn Herreman]

It doesn't happen with a clean profile, and with your suggestion I've found that the *Adobe Acrobat DC - Create PDF 15.01.03* add-on causes the problem.

The add-on is not installed through AMO, it comes with the Adobe Creative Cloud installer.

I've disabled the add-on since I don't use it, but I'm not sure how to proceed now. Should I report this issue to Adobe? Or do you have a process in place to handle broken add-ons?

Comment 5

[:Gijs (he/him)]

(In reply to Stijn Herreman from comment #4)
> It doesn't happen with a clean profile, and with your suggestion I've found
> that the *Adobe Acrobat DC - Create PDF 15.01.03* add-on causes the problem.

Wuh. I wonder what they're doing that's breaking this... That's just mad. :-\

Out of curiosity, does anything show up in the browser console when this happens, esp. when opening a new window?

> The add-on is not installed through AMO, it comes with the Adobe Creative
> Cloud installer.

Even better, sideloaded add-ons...

> I've disabled the add-on since I don't use it, but I'm not sure how to
> proceed now. Should I report this issue to Adobe? Or do you have a process
> in place to handle broken add-ons?

Well, "process" makes it sound formal and settled and straightforward, and I don't know that it is, but I can move this to the evangelism component and ping Jorge and Andreas. Maybe they have contacts with Adobe who could take a look. (Jorge/Andreas: if not, please forward to Dees in case he knows someone.)

Of course, our long-term plan here is the switch to webextensions which will make this problem go away.

Comment 6

[Stijn Herreman]

(In reply to :Gijs from comment #5)
> Out of curiosity, does anything show up in the browser console when this
> happens, esp. when opening a new window?

Nothing to see in the console. I've also tried launching with "C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -jsconsole but there's nothing out of the ordinary.

Comment 7

[Andreas Wagner [:TheOne] [use NI]]

Stijn, would you mind providing the ID for the mentioned add-on? You can find it on about:support in the extensions section. Thank you.

Comment 8

[Stijn Herreman]

The ID is [e-mail]

Comment 9

[Andreas Wagner [:TheOne] [use NI]]

I reached out to the developer and referred them to this bug.

Comment 10

[Andreas Wagner [:TheOne] [use NI]]

Also, thank you, Stijn.

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Mass-closing bugs that relate to legacy versions of add-ons or are otherwise no longer worth tracking. Please comment if you think this bug should be reopened.

Sorry for the bugspam. Made you look, though!