Closed Bug 1359001 Opened 3 years ago Closed 3 years ago

AutoAssertGCCallback calls into the JS engine in opt builds

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

This class is used to assert that we're currently running inside a GC callback.  It doesn't do anything in opt builds, but currently it calls into the JS engine anyway.
Patch to make the constructor an empty inline method in opt builds.  Also remove the unused JSObject* parameter.
Attachment #8861052 - Flags: review?(jdemooij)
Attachment #8861052 - Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5633dacc482d
Make AutoAssertGCCallback a no-op in opt builds r=sfink
https://hg.mozilla.org/mozilla-central/rev/5633dacc482d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.