1359006 - The localized name of Top Sites tab switched from 1 line to 2

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Artem Polivanchuk]

Attachment: Screenshot_Nightly.png

Looking at the Ukrainian Firefox for Android (Nightly) I found out that the name of Top Sites tab on home screen switched from 1 line to 2.

The localized string mobile/android/base/android_strings.dtd:home_top_sites_title related to the name of tab has not changed.
I also see that there is enough space for displaying names of all the home screen tabs in 1 line.

Please check the attached screenshot and make nessecary adjustments to fix it.

Thanks!

Comment 1

[Artem Polivanchuk]

Attachment: Screenshot_Release.png

The same screen looks OK in release.

Comment 2

[Piotr Drąg [:piotrdrag]]

Attachment: Polish home screen on Nightly

I see the same problem in Polish localization, even though there is no space in the string — the word gets split at the last letter.

Comment 3

[Francesco Lodolo [:flod]]

Sebastian, any idea of what changed and who could help?

Comment 4

[Max Liu [:maliu]]

Not sure which patch cause this regression. Let's put this into triage meeting.

Comment 5

[Sorina Florean [:sflorean]]

I was able to reproduce this issue with both Polish and Ukrainian languages on device HTC Desire 820 (Android 6.0.1).

Regression-window:
Last good build: 04-20
First bad build: 04-21
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=27311156637f9b5d4504373967e01c4241902ae7&tochange=c8198aa6e7677e90cc7f1e2df0a14a5cc2719055

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Tracking Requested - why for this release]:

likely a regression from bookmark management.

Comment 7

[Jing-wei Wu [:jwu]]

This is a side effect of Bug 1232439. In patch part 4 we modified the UI layout to make the name of each panel shares same width. The change caused "top-site" panel don't have enough space to show its name and wrap it into 2 lines.

We should revert the UI change to prevent this regression.

Comment 8

[Jing-wei Wu [:jwu]]

Attachment: Bug 1359006 - Remove gecko:titlebarFill in layout to prevent panel name be wrapped.

Review commit: https://reviewboard.mozilla.org/r/140582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140582/

Comment 9

[Julien Cristau [:jcristau]]

tracking as new regression in 55.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8868930 [details]
Bug 1359006 - Remove gecko:titlebarFill in layout to prevent panel name be wrapped.

https://reviewboard.mozilla.org/r/140582/#review145536

LGTM.

Do we need to request uplift?

Comment 11

[Jing-wei Wu [:jwu]]

(In reply to Sebastian Kaspari (:sebastian) from comment #10)
> Comment on attachment 8868930 [details]
> Bug 1359006 - Remove gecko:titlebarFill in layout to prevent panel name be
> wrapped.
> 
> https://reviewboard.mozilla.org/r/140582/#review145536
> 
> LGTM.
> 
> Do we need to request uplift?

This regression just affects on Nightly, it shouldn't need uplift.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/934520f4b7a0
Remove gecko:titlebarFill in layout to prevent panel name be wrapped. r=sebastian

Comment 13

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/934520f4b7a0

Comment 14

[Sorina Florean [:sflorean]]

Verified as fixed in build 55.0a1 (2017/05/25).
Device: HTC 10 (Android 7.0).

Comment 15

[Bogdan Surd, QA [:bsurd, NI]]

Verified on multiple languages in 55.0b3 and the issue was not reproducible, if the text was longer the top sites panel would become scrollable, marking as verified. 
Device: Nexus 6 (Android 6.0.1).