Closed Bug 1359006 Opened 4 years ago Closed 4 years ago

The localized name of Top Sites tab switched from 1 line to 2

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

All
Android
defect

Tracking

(fennec55+, firefox53 unaffected, firefox54 unaffected, firefox55+ verified)

VERIFIED FIXED
Firefox 55
Tracking Status
fennec 55+ ---
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 + verified

People

(Reporter: a.polivanchuk, Assigned: jwu)

Details

(Keywords: regression)

Attachments

(4 files)

Attached image Screenshot_Nightly.png
Looking at the Ukrainian Firefox for Android (Nightly) I found out that the name of Top Sites tab on home screen switched from 1 line to 2.

The localized string mobile/android/base/android_strings.dtd:home_top_sites_title related to the name of tab has not changed.
I also see that there is enough space for displaying names of all the home screen tabs in 1 line.

Please check the attached screenshot and make nessecary adjustments to fix it.

Thanks!
Attached image Screenshot_Release.png
The same screen looks OK in release.
I see the same problem in Polish localization, even though there is no space in the string — the word gets split at the last letter.
Attachment #8866711 - Attachment description: Polish home screen → Polish home screen on Nightly
Sebastian, any idea of what changed and who could help?
Flags: needinfo?(s.kaspari)
tracking-fennec: --- → ?
Flags: needinfo?(s.kaspari) → needinfo?(max)
Not sure which patch cause this regression. Let's put this into triage meeting.
Flags: needinfo?(max)
OS: Unspecified → Android
Hardware: Unspecified → All
I was able to reproduce this issue with both Polish and Ukrainian languages on device HTC Desire 820 (Android 6.0.1).

Regression-window:
Last good build: 04-20
First bad build: 04-21
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=27311156637f9b5d4504373967e01c4241902ae7&tochange=c8198aa6e7677e90cc7f1e2df0a14a5cc2719055
[Tracking Requested - why for this release]:

likely a regression from bookmark management.
Assignee: nobody → topwu.tw
tracking-fennec: ? → 55+
Priority: -- → P1
This is a side effect of Bug 1232439. In patch part 4 we modified the UI layout to make the name of each panel shares same width. The change caused "top-site" panel don't have enough space to show its name and wrap it into 2 lines.

We should revert the UI change to prevent this regression.
tracking as new regression in 55.
Comment on attachment 8868930 [details]
Bug 1359006 - Remove gecko:titlebarFill in layout to prevent panel name be wrapped.

https://reviewboard.mozilla.org/r/140582/#review145536

LGTM.

Do we need to request uplift?
Attachment #8868930 - Flags: review?(s.kaspari) → review+
(In reply to Sebastian Kaspari (:sebastian) from comment #10)
> Comment on attachment 8868930 [details]
> Bug 1359006 - Remove gecko:titlebarFill in layout to prevent panel name be
> wrapped.
> 
> https://reviewboard.mozilla.org/r/140582/#review145536
> 
> LGTM.
> 
> Do we need to request uplift?

This regression just affects on Nightly, it shouldn't need uplift.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/934520f4b7a0
Remove gecko:titlebarFill in layout to prevent panel name be wrapped. r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/934520f4b7a0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified as fixed in build 55.0a1 (2017/05/25).
Device: HTC 10 (Android 7.0).
Status: RESOLVED → VERIFIED
Verified on multiple languages in 55.0b3 and the issue was not reproducible, if the text was longer the top sites panel would become scrollable, marking as verified. 
Device: Nexus 6 (Android 6.0.1).
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.