1359028 - The red dashed outline Browser Toolbox highlighter is gone

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Patrick Brosset <:pbro>]

STR:
- open nightly
- open the Browser Toolbox
- click on the element picker icon
- move your mouse over the main browser window to select an element (like a tab)

Expected: there should be a red dashed outline that indicates which element is currently hovered

Actual: the outline is gone, making it hard to select elements and see which one is currently selected/hovered in the Browser Toolbox markup-view.

This seems to be very recent, maybe in the last couple of days. 
Maybe bug 1353005 is the culprit?

Comment 1

[Patrick Brosset <:pbro>]

Matteo, Julian just confirmed to me on IRC that this was indeed related ot bug 135005. Do you mind taking a look at this regression please?

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Bug 1359028 - added encodeURIComponent and fixed css class typo;

The patch of bug 1353005 removed by mistake a leading dot in a css class, and
the `encodeURIComponent` calls (so the # in the color definition was considered
the hash part in the url).
Also, it happears autoland rejected the last commit from Bug 1353005, so this
patch includes those changes as well.

Review commit: https://reviewboard.mozilla.org/r/133056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133056/

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

The patch of bug 1353005 removed by mistake a leading dot in a css class, and the `encodeURIComponent` calls (so the # in the color definition was considered the hash part in the url).

Also, it appears autoland rejected the last commit from Bug 1353005, so this patch includes those changes as well.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8861073 [details]
Bug 1359028 - added encodeURIComponent and fixed css class typo;

https://reviewboard.mozilla.org/r/133056/#review136056

Thanks for fixing this quickly!

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8861073 [details]
Bug 1359028 - added encodeURIComponent and fixed css class typo;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133056/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5046bec1e8ea
added encodeURIComponent and fixed css class typo; r=pbro

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5046bec1e8ea