The red dashed outline Browser Toolbox highlighter is gone

RESOLVED FIXED in Firefox 55

Status

P1
normal
RESOLVED FIXED
2 years ago
7 months ago

People

(Reporter: pbro, Assigned: zer0)

Tracking

({regression})

unspecified
Firefox 55
regression
Bug Flags:
in-qa-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox-esr52 unaffected)

Details

(Whiteboard: [nosdk])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
STR:
- open nightly
- open the Browser Toolbox
- click on the element picker icon
- move your mouse over the main browser window to select an element (like a tab)

Expected: there should be a red dashed outline that indicates which element is currently hovered

Actual: the outline is gone, making it hard to select elements and see which one is currently selected/hovered in the Browser Toolbox markup-view.

This seems to be very recent, maybe in the last couple of days. 
Maybe bug 1353005 is the culprit?
(Reporter)

Comment 1

2 years ago
Matteo, Julian just confirmed to me on IRC that this was indeed related ot bug 135005. Do you mind taking a look at this regression please?
Blocks: 1353005
Flags: needinfo?(zer0)
Keywords: regression
(Reporter)

Updated

2 years ago
status-firefox54: --- → unaffected
status-firefox55: --- → affected
(Assignee)

Updated

2 years ago
Assignee: nobody → zer0
Flags: needinfo?(zer0)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

2 years ago
The patch of bug 1353005 removed by mistake a leading dot in a css class, and the `encodeURIComponent` calls (so the # in the color definition was considered the hash part in the url).

Also, it appears autoland rejected the last commit from Bug 1353005, so this patch includes those changes as well.
(Reporter)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8861073 [details]
Bug 1359028 - added encodeURIComponent and fixed css class typo;

https://reviewboard.mozilla.org/r/133056/#review136056

Thanks for fixing this quickly!
Attachment #8861073 - Flags: review?(pbrosset) → review+
Comment hidden (mozreview-request)

Comment 6

2 years ago
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5046bec1e8ea
added encodeURIComponent and fixed css class typo; r=pbro

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5046bec1e8ea
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
status-firefox53: --- → unaffected
status-firefox-esr52: --- → unaffected
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [nosdk]

Updated

8 months ago
Product: Firefox → DevTools
status-firefox53: unaffected → ---
status-firefox54: unaffected → ---
status-firefox55: fixed → ---
Flags: in-qa-testsuite+
You need to log in before you can comment on or make changes to this bug.