The red dashed outline Browser Toolbox highlighter is gone

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Inspector
P1
normal
RESOLVED FIXED
6 months ago
3 months ago

People

(Reporter: pbro, Assigned: zer0)

Tracking

({regression})

unspecified
Firefox 55
regression
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

(Whiteboard: [nosdk])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
STR:
- open nightly
- open the Browser Toolbox
- click on the element picker icon
- move your mouse over the main browser window to select an element (like a tab)

Expected: there should be a red dashed outline that indicates which element is currently hovered

Actual: the outline is gone, making it hard to select elements and see which one is currently selected/hovered in the Browser Toolbox markup-view.

This seems to be very recent, maybe in the last couple of days. 
Maybe bug 1353005 is the culprit?
(Reporter)

Comment 1

6 months ago
Matteo, Julian just confirmed to me on IRC that this was indeed related ot bug 135005. Do you mind taking a look at this regression please?
Blocks: 1353005
Flags: needinfo?(zer0)
Keywords: regression
(Reporter)

Updated

6 months ago
status-firefox54: --- → unaffected
status-firefox55: --- → affected
(Assignee)

Updated

6 months ago
Assignee: nobody → zer0
Flags: needinfo?(zer0)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

6 months ago
The patch of bug 1353005 removed by mistake a leading dot in a css class, and the `encodeURIComponent` calls (so the # in the color definition was considered the hash part in the url).

Also, it appears autoland rejected the last commit from Bug 1353005, so this patch includes those changes as well.
(Reporter)

Comment 4

6 months ago
mozreview-review
Comment on attachment 8861073 [details]
Bug 1359028 - added encodeURIComponent and fixed css class typo;

https://reviewboard.mozilla.org/r/133056/#review136056

Thanks for fixing this quickly!
Attachment #8861073 - Flags: review?(pbrosset) → review+
Comment hidden (mozreview-request)

Comment 6

6 months ago
Pushed by mferretti@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5046bec1e8ea
added encodeURIComponent and fixed css class typo; r=pbro

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5046bec1e8ea
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
status-firefox53: --- → unaffected
status-firefox-esr52: --- → unaffected

Updated

3 months ago
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [nosdk]
You need to log in before you can comment on or make changes to this bug.