1359033 - [notifications] Fix sending new string notifications

Status: RESOLVED MOVED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Matjaz Horvat [:mathjazz]]

There are a few cases when we send new strings notifications but we shouldn't, and vice versa.

We do not send notifications, but we should:

- If new symmetric (bilingual) file is enabled for a locale (e.g. in Mozilla.org), we should notify contibutors of that localization about new strings. Currently we don't send any notifications when such event occurs.

We do send notifications, but we should not:

- If we not only add new strings, but also pretranslate them in repository using existing translations (e.g. on merge to Firefox Beta or when files are moved in the l10n repo on merge day), we shouldn't notify project contributors about them.

- If source strings are different depending on locale (e.g. Mozilla.org or Engagement), we should send notifications only to contibutors of locales for which the new strings were added. Currently we notify all project contributors, even if new strings are only enabled for a handful of locales.

- If a project is private, we send new string notifications to all translation authors within that project. That doesn't sound wrong on a first look, but if the project had been public in the past and is not private, there might be false positives among the recipients. So we must only send notifications to users that have access to the project at the time of sending a notification.

Comment 2

[BMO Automation]

*This bug has been moved to GitHub.*

*Please check it out on https://github.com/mozilla/pontoon/issues.*