1359050 - Test if element is in view with pointer events enabled

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette should test that the element to be clicked is in-view with pointer-events enabled, following a recent change to the specification:

    https://github.com/w3c/webdriver/commit/ba6ee925b5bc85938d542d65ef5034a761fe73d7

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1359050 - Test element in view with pointer events enabled;

This change makes it possible to click elements that has its
pointer-events style property set to "none".

If an element has its style property pointer-events set to "none",
the element in view test will fail due to document.elementsFromPoint
excluding it due to non-interactability.  This is only a problem when
checking if the element is inside the viewport, and not when actually
performing interaction with the element.

The relevant specification change is
https://github.com/w3c/webdriver/commit/ba6ee925b5bc85938d542d65ef5034a761fe73d7.

Review commit: https://reviewboard.mozilla.org/r/132970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132970/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8860960 [details]
Bug 1359050 - Test element in view with pointer events enabled;

https://reviewboard.mozilla.org/r/132970/#review135968

::: testing/marionette/harness/marionette_harness/tests/unit/test_click.py:278
(Diff revision 1)
> +        button = self.marionette.find_element(By.TAG_NAME, "button")
> +        self.assertEqual("none", button.value_of_css_property("pointer-events"))
> +
> +        with self.assertRaisesRegexp(errors.ElementClickInterceptedException,
> +                                     "does not have pointer events enabled"):
> +            button.click()

I just realised this is missing a test for window.clicks.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8860960 [details]
Bug 1359050 - Test element in view with pointer events enabled;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132970/diff/1-2/

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8860960 [details]
Bug 1359050 - Test element in view with pointer events enabled;

https://reviewboard.mozilla.org/r/132970/#review136254

Looks good. One question about tests.

::: testing/marionette/element.js:900
(Diff revision 1)
> +  try {
> +    el.style.pointerEvents = "auto";
> +    const tree = element.getPointerInteractablePaintTree(el);
> -  return tree.includes(el);
> +    return tree.includes(el);
> +  } finally {
> +    el.style.pointerEvents = originalPointerEvents;
> +  }

Are any tests exercising this code path?

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8860960 [details]
Bug 1359050 - Test element in view with pointer events enabled;

https://reviewboard.mozilla.org/r/132970/#review136254

> Are any tests exercising this code path?

Only test_pointer_events_none in test_click.py.  test_accessibility.py also uses click on element’s with pointer-events: none, but they do not currently use element.isInView.  They will once I switch Marionette over to using the WebDriver-conforming Element Click implementation in https://bugzilla.mozilla.org/show_bug.cgi?id=1321516.

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8860960 [details]
Bug 1359050 - Test element in view with pointer events enabled;

https://reviewboard.mozilla.org/r/132970/#review136254

> Only test_pointer_events_none in test_click.py.  test_accessibility.py also uses click on element’s with pointer-events: none, but they do not currently use element.isInView.  They will once I switch Marionette over to using the WebDriver-conforming Element Click implementation in https://bugzilla.mozilla.org/show_bug.cgi?id=1321516.

Okay, thumbs up.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0280c5b6d617
Test element in view with pointer events enabled; r=maja_zf

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0280c5b6d617