1359059 - Skip visibility checks when clicking XUL elements in Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

As title.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1359059 - Skip visibility checks when clicking in XUL;

This patch removes the call to element.isVisible when clicking XUL
elements because it does not do anything useful.  element.isVisible skips
the Selenium atom.isElementDisplayed check for XUL elements and runs a
few web content/viewport centric tests that always pass in XUL.

It also splits the chrome click out to a separate function to avoid a
few if-conditions.

Review commit: https://reviewboard.mozilla.org/r/132988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132988/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8860970 [details]
Bug 1359059 - Skip visibility checks when clicking in XUL;

https://reviewboard.mozilla.org/r/132988/#review136070

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2c1bba57c7b
Skip visibility checks when clicking in XUL; r=whimboo

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c2c1bba57c7b