1359125 - Export strings for 8.0

Status: RESOLVED FIXED

(Firefox for iOS :: Localization, enhancement)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-l10n/firefoxios-l10n/pull/25

@flodolo I don't know what to do with these two:

- `HistoryPanel.RecentlyClosedTabsButton.Title`
- `HistoryPanel.SyncedTabsCell.Title`

It is just capitalization that changed. It invalidates all these strings in all languages, that does not seem to practical.

What is the best way to handle this?

Comment 1

[Francesco Lodolo [:flod]]

I've replied in GitHub, but answering here too.

The update script stores an hash of the reference string, and if it changes it basically invalidates the existing translation. 
https://github.com/mozilla-mobile/firefox-ios-build-tools/blob/master/scripts/update-xliff.py#L130

That was done on purpose, because we had strings changing without changing ID, and those modifications were missed. IIRC it was one of the CFBundle keys.

You can:
* Temporarily hack the update script to allow these two changes, e.g. replace hash() with a fixed text.
* Make that a switch that you can use when invoking the script, and to use only after you've checked the diff for en-US.
* Remove those controls if we feel confident that we're not going to mess up in the future.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-l10n/firefoxios-l10n/pull/26

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 8861275 [details] [review]
PR https://github.com/mozilla-l10n/firefoxios-l10n/pull/26

Redirecting to Delphine. As commented in GitHub, I don't see anything wrong besides a couple of comments that could be improved at the first chance.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Landed the strings.