Closed
Bug 1359125
Opened 7 years ago
Closed 7 years ago
Export strings for 8.0
Categories
(Firefox for iOS :: Localization, enhancement)
Tracking
()
RESOLVED
FIXED
Iteration:
1.20
Tracking | Status | |
---|---|---|
fxios | 8.0+ | --- |
People
(Reporter: st3fan, Assigned: st3fan)
Details
Attachments
(1 file, 1 obsolete file)
@flodolo I don't know what to do with these two: - `HistoryPanel.RecentlyClosedTabsButton.Title` - `HistoryPanel.SyncedTabsCell.Title` It is just capitalization that changed. It invalidates all these strings in all languages, that does not seem to practical. What is the best way to handle this?
Assignee | ||
Updated•7 years ago
|
Iteration: --- → 1.20
tracking-fxios:
--- → 8.0+
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(francesco.lodolo)
Comment 1•7 years ago
|
||
I've replied in GitHub, but answering here too. The update script stores an hash of the reference string, and if it changes it basically invalidates the existing translation. https://github.com/mozilla-mobile/firefox-ios-build-tools/blob/master/scripts/update-xliff.py#L130 That was done on purpose, because we had strings changing without changing ID, and those modifications were missed. IIRC it was one of the CFBundle keys. You can: * Temporarily hack the update script to allow these two changes, e.g. replace hash() with a fixed text. * Make that a switch that you can use when invoking the script, and to use only after you've checked the diff for en-US. * Remove those controls if we feel confident that we're not going to mess up in the future.
Flags: needinfo?(francesco.lodolo)
Assignee | ||
Comment 2•7 years ago
|
||
Assignee: nobody → sarentz
Attachment #8861090 -
Attachment is obsolete: true
Attachment #8861275 -
Flags: review?(francesco.lodolo)
Comment 3•7 years ago
|
||
Comment on attachment 8861275 [details] [review] PR https://github.com/mozilla-l10n/firefoxios-l10n/pull/26 Redirecting to Delphine. As commented in GitHub, I don't see anything wrong besides a couple of comments that could be improved at the first chance.
Attachment #8861275 -
Flags: review?(francesco.lodolo) → review?(lebedel.delphine)
Assignee | ||
Comment 4•7 years ago
|
||
Landed the strings.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Attachment #8861275 -
Flags: review?(lebedel.delphine)
You need to log in
before you can comment on or make changes to this bug.
Description
•