Status

()

Firefox for iOS
Localization
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
Created attachment 8861090 [details] [review]
PR https://github.com/mozilla-l10n/firefoxios-l10n/pull/25

@flodolo I don't know what to do with these two:

- `HistoryPanel.RecentlyClosedTabsButton.Title`
- `HistoryPanel.SyncedTabsCell.Title`

It is just capitalization that changed. It invalidates all these strings in all languages, that does not seem to practical.

What is the best way to handle this?
(Assignee)

Updated

a year ago
Iteration: --- → 1.20
tracking-fxios: --- → 8.0+
(Assignee)

Updated

a year ago
Flags: needinfo?(francesco.lodolo)
I've replied in GitHub, but answering here too.

The update script stores an hash of the reference string, and if it changes it basically invalidates the existing translation. 
https://github.com/mozilla-mobile/firefox-ios-build-tools/blob/master/scripts/update-xliff.py#L130

That was done on purpose, because we had strings changing without changing ID, and those modifications were missed. IIRC it was one of the CFBundle keys.

You can:
* Temporarily hack the update script to allow these two changes, e.g. replace hash() with a fixed text.
* Make that a switch that you can use when invoking the script, and to use only after you've checked the diff for en-US.
* Remove those controls if we feel confident that we're not going to mess up in the future.
Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 2

a year ago
Created attachment 8861275 [details] [review]
PR https://github.com/mozilla-l10n/firefoxios-l10n/pull/26
Assignee: nobody → sarentz
Attachment #8861090 - Attachment is obsolete: true
Attachment #8861275 - Flags: review?(francesco.lodolo)
Comment on attachment 8861275 [details] [review]
PR https://github.com/mozilla-l10n/firefoxios-l10n/pull/26

Redirecting to Delphine. As commented in GitHub, I don't see anything wrong besides a couple of comments that could be improved at the first chance.
Attachment #8861275 - Flags: review?(francesco.lodolo) → review?(lebedel.delphine)
(Assignee)

Comment 4

a year ago
Landed the strings.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Attachment #8861275 - Flags: review?(lebedel.delphine)
You need to log in before you can comment on or make changes to this bug.