Closed Bug 1359130 Opened 7 years ago Closed 7 years ago

Remove NetUtil.jsm overhead from the search service initialization

Categories

(Firefox :: Search, enhancement, P1)

Product:
Firefox
Component:
Search
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Iteration:
55.4 - May 1
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-performance][fxsearch])

Attachments

(2 files)

stop using NetUtil.jsm in the search service
10.11 KB, patch
adw
: review+
Details | Diff | Splinter Review
stop using FileUtils.jsm in the search service
5.95 KB, patch
adw
: review+
Details | Diff | Splinter Review
Here is a profile where 2 NetUtil_newURI calls are visible while running SRCH_ENG__initWithJSON. We also have one visible NetUtil_newChannel call. https://perfht.ml/2pYfmtV
Flags: qe-verify?
Priority: -- → P2
Assignee: nobody → florian
Status: NEW → ASSIGNED
Iteration: --- → 55.4 - May 1
Priority: P2 → P1
Attachment #8861114 - Flags: review?(adw) → review+
Attachment #8861115 - Flags: review?(adw) → review+
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/97aa64b88c95 stop using NetUtil.jsm in the search service, r=adw. https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe7c97cb182 stop using FileUtils.jsm in the search service, r=adw.
Flags: qe-verify? → qe-verify-
https://hg.mozilla.org/mozilla-central/rev/97aa64b88c95 https://hg.mozilla.org/mozilla-central/rev/7fe7c97cb182
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
No longer blocks: photon-performance-triage
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: