Remove NetUtil.jsm overhead from the search service initialization

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-performance][fxsearch])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Here is a profile where 2 NetUtil_newURI calls are visible while running SRCH_ENG__initWithJSON. We also have one visible NetUtil_newChannel call.

https://perfht.ml/2pYfmtV

Updated

2 years ago
Flags: qe-verify?
Priority: -- → P2
(Assignee)

Comment 1

2 years ago
Created attachment 8861114 [details] [diff] [review]
stop using NetUtil.jsm in the search service
Attachment #8861114 - Flags: review?(adw)
(Assignee)

Updated

2 years ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8861115 [details] [diff] [review]
stop using FileUtils.jsm in the search service
Attachment #8861115 - Flags: review?(adw)

Updated

2 years ago
Iteration: --- → 55.4 - May 1
Priority: P2 → P1

Updated

2 years ago
Attachment #8861114 - Flags: review?(adw) → review+

Updated

2 years ago
Attachment #8861115 - Flags: review?(adw) → review+

Comment 3

2 years ago
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/97aa64b88c95
stop using NetUtil.jsm in the search service, r=adw.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe7c97cb182
stop using FileUtils.jsm in the search service, r=adw.

Updated

2 years ago
Flags: qe-verify? → qe-verify-

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/97aa64b88c95
https://hg.mozilla.org/mozilla-central/rev/7fe7c97cb182
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Updated

2 years ago
No longer blocks: 1348289
(Assignee)

Updated

2 years ago
Blocks: 1348289
You need to log in before you can comment on or make changes to this bug.