If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Intermittent test_ChildHistograms.js | application crashed [@ CrashReporter::AnnotateCrashReport(nsACString const &,nsACString const &)]

RESOLVED INCOMPLETE

Status

()

Core
IPC
--
critical
RESOLVED INCOMPLETE
5 months ago
3 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: billm)

Tracking

({bulk-close-intermittents, crash, intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
treeherder
Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=93722897&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1493030539/mozilla-inbound_win7_vm-debug_test-xpcshell-bm129-tests1-windows-build368.txt.gz
It looks like MessageChannel::WillDestroyMessageLoop() [1] is calling AnnotateCrashReport() off-mainthread, which asserts.
Bill, i see you in the blame for WillDestroyCurrentMessageLoop()?

> 05:13:22     INFO -  Crash reason:  EXCEPTION_BREAKPOINT
> 05:13:22     INFO -  Crash address: 0x60f83eb7
> 05:13:22     INFO -  Assertion: Unknown assertion type 0x00000000
> 05:13:22     INFO -  Process uptime: 11 seconds
> 05:13:22     INFO -  Thread 4 (crashed)
> 05:13:22     INFO -   0  xul.dll!CrashReporter::AnnotateCrashReport(nsACString const &,nsACString const &) [nsExceptionHandler.cpp:ccdbdd6e79e3 : 2355 + 0x18]
> 05:13:22     INFO -      eip = 0x60f83eb7   esp = 0x03a3f974   ebp = 0x03a3fa54   ebx = 0x03a3fa68
> 05:13:22     INFO -      esi = 0x00000933   edi = 0x03a3fa74   eax = 0x00000000   ecx = 0x6cf906ef
> 05:13:22     INFO -      edx = 0x00000060   efl = 0x00000216
> 05:13:22     INFO -      Found by: given as instruction pointer in context
> 05:13:22     INFO -   1  xul.dll!mozilla::ipc::MessageChannel::WillDestroyCurrentMessageLoop() [MessageChannel.cpp:ccdbdd6e79e3 : 680 + 0x2a]
> 05:13:22     INFO -      eip = 0x5eba81d6   esp = 0x03a3fa5c   ebp = 0x03a3fa80
> 05:13:22     INFO -      Found by: call frame info
...
> Assertion failure: NS_IsMainThread(), at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/toolkit/crashreporter/nsExceptionHandler.cpp:2355


1: https://hg.mozilla.org/mozilla-central/annotate/abdcc8dfc28397b95338245390e12c56658ad182/ipc/glue/MessageChannel.cpp#l676
Flags: needinfo?(wmccloskey)
Component: Telemetry → IPC
Product: Toolkit → Core
(Assignee)

Comment 2

5 months ago
I filed bug 1360697 for the media issue here. The assertion is easy to fix.
Flags: needinfo?(wmccloskey)
(Assignee)

Comment 3

5 months ago
Created attachment 8863041 [details] [diff] [review]
patch

See https://bugzilla.mozilla.org/show_bug.cgi?id=1338310#c3. I guess I was wrong that this would never happen.
Assignee: nobody → wmccloskey
Attachment #8863041 - Flags: review?(dvander)
Comment on attachment 8863041 [details] [diff] [review]
patch

Talked about this in person but, I think this is expected since the GPU process shuts down the crash reporter shmem before all actors have necessarily closed down.
Attachment #8863041 - Flags: review?(dvander)
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Keywords: bulk-close-intermittents
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.