1359223 - Checkstyle not being run on geckoview

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Mike Kaply [:mkaply]]

Checkstyle is not being run on geckoview, so we're running into issues backporting.

This bug adds it and corrects style issues.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1359223 - Add geckoview to checkstyle and correct style issues.

Review commit: https://reviewboard.mozilla.org/r/133140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133140/

Comment 2

[Mike Kaply [:mkaply]]

Comment on attachment 8861178 [details]
Bug 1359223 - Add geckoview to checkstyle and correct style issues.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133140/diff/1-2/

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8861178 [details]
Bug 1359223 - Add geckoview to checkstyle and correct style issues.

https://reviewboard.mozilla.org/r/133140/#review136264

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/314315c93bbc
Add geckoview to checkstyle and correct style issues. r=snorp

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/314315c93bbc