Disable the add new jobs button when signed out instead of hiding it

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: KWierso, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
12:51:21 <nalexander> How do I manually trigger jobs in TH these days?
12:52:44 <KWierso> nalexander: go to the push you want the jobs on, hit the 'v' button at the end of the row, "Add new jobs"
12:53:00 <KWierso> need to be signed in with an account that has some LDAP permissions
12:53:07 <nalexander> KWierso: thanks, I will try that.  For what it's worth, I couldn't find anything like that when I tried before.
12:53:52 <KWierso> only visibility constraint I see is "isLoggedIn"
12:54:39 <KWierso> well, "loggedIn", I guess
13:54:54 <wlach> we should show the option but disable it if the user is not logged in

Comment 1

10 months ago
Created attachment 8861188 [details] [review]
[treeherder] KWierso:addnewjobsvisibility > mozilla:master
(Assignee)

Updated

10 months ago
Attachment #8861188 - Flags: review?(emorley)

Updated

10 months ago
Attachment #8861188 - Flags: review?(emorley) → review+

Comment 2

10 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c978b097a62fde70db84f067e121450186d704a9
Bug 1359238 - Disable the 'Add new jobs' button instead of hiding it (#2421) r=emorley
(Assignee)

Updated

10 months ago
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED

Updated

10 months ago
Depends on: 1360621
You need to log in before you can comment on or make changes to this bug.