43 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
I didn't realize Sentry had a logging integration when I was adding Sentry-related capture bits to Antenna. https://docs.sentry.io/clients/python/integrations/logging/ This bug covers changing that out for logging integration method.
As a side note, I just looked into this and it's non-trivial. We'd have to go through and change the retryable code so that it somehow didn't log exceptions for things it's retrying. When I wrote this up, I thought this would be an easy change that would result in code removal, but I'm pretty sure that's not the case. Going to keep this open for a bit longer while I mull over the issues, but probably close it as WONTFIX..
I'm still interested in doing this. I think we should do the following: 1. Undo the "make traceback all one line" code and verify that logging.exception works right with mozlog. 2. If that's good, go through and change any logging.exception() calls that aren't logging something that's dire and should get looked into pronto to logging.warning or something like that. 3. After that, add the Sentry logger for exceptions. 4. After that, nix some of the Sentry-related capture bits we have. Theoretically, that will put us in a better place for error notification, reduces the code a bit, and cleans up some of the error handling.
Created attachment 8864298 [details] [review] Link to Github pull-request: https://github.com/mozilla/antenna/pull/232
Landed this, saw it get to -dev, deployed it to -stage. Marking as FIXED.