Closed Bug 1359314 Opened 4 years ago Closed 4 years ago

Apply mask layer transform when building wr mask layer

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

(Blocks 1 open bug)

Details

(Keywords: correctness)

Attachments

(1 file)

We should apply mask layer's transform or the position may be wrong. The mask layer's coordinate should be same as the masked layer. But for WebRenderXXXLayer, we already create a stacking context, so we need to deduct the offset of the stacking context.
A relative reftest is 'layout/reftests/w3c-css/submitted/shapes1/shape-outside-circle-033.html'. The mask layer's transform is not a identity matrix.
I also checked the reftest in bug 1354464. The tests are all passed with the patch.
Attachment #8861297 - Flags: review?(mchang)
Attachment #8861297 - Flags: review?(mchang) → review+
Per try result[1], there is some unexpected-pass tests. I will remove the fails-if flag. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b01e30368286633cf349afed8a64932092c29585&selectedJob=94388585
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8ac463bab104
Apply mask layer transform when building webrender mask layer. r=mchang
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.