1359314 - Apply mask layer transform when building wr mask layer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

We should apply mask layer's transform or the position may be wrong. The mask layer's coordinate should be same as the masked layer. But for WebRenderXXXLayer, we already create a stacking context, so we need to deduct the offset of the stacking context.

Comment 1

[Ethan Lin[:ethlin]]

A relative reftest is 'layout/reftests/w3c-css/submitted/shapes1/shape-outside-circle-033.html'. The mask layer's transform is not a identity matrix.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: apply mask layer's transform

I also checked the reftest in bug 1354464. The tests are all passed with the patch.

Comment 3

[Ethan Lin[:ethlin]]

Per try result[1], there is some unexpected-pass tests. I will remove the fails-if flag. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b01e30368286633cf349afed8a64932092c29585&selectedJob=94388585

Comment 4

[Ethan Lin[:ethlin]]

try result is good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd74d27eb84d7190b2b67c26321f77db53ff8886

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/8ac463bab104
Apply mask layer transform when building webrender mask layer. r=mchang

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/8ac463bab104