Closed Bug 1359315 Opened 4 years ago Closed 4 years ago

don't use data: URI for test_bug1101364.html

Categories

(Core :: DOM: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 1 obsolete file)

This test uses data: URI, when we turn off the pref security.data_uri.inherit_security_context, accessing iframe.contentDocument will become null.
Attached patch Patch. (obsolete) — Splinter Review
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Attachment #8861296 - Flags: review?(ckerschb)
Comment on attachment 8861296 [details] [diff] [review]
Patch.

Review of attachment 8861296 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me, but I am not a dom-peer, hence I can't sign off on it.
Attachment #8861296 - Flags: review?(ckerschb) → feedback+
Priority: -- → P2
Whiteboard: [domsecurity-active]
Comment on attachment 8861296 [details] [diff] [review]
Patch.

Couldn't we use srcdoc in this kind of cases?
Attachment #8861296 - Flags: review?(bugs) → review+
Attached patch Patch. v2Splinter Review
Thanks for smaug's suggestion, converted it to use srcdoc.
Attachment #8861296 - Attachment is obsolete: true
Attachment #8862345 - Flags: review+
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/6f1e99e90c67
don't use data: URI for test_bug1101364.html. r=smaug
https://hg.mozilla.org/mozilla-central/rev/6f1e99e90c67
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.