Closed
Bug 1359316
Opened 7 years ago
Closed 7 years ago
(intersection-observer) Intersection ratio should be 1.0 for zero-area intersections
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: tschneider, Assigned: tschneider)
References
Details
Attachments
(1 file, 2 obsolete files)
3.15 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Set intersection ratio to 1.0 for zero-area (width or/and height 0) intersections.
Assignee | ||
Updated•7 years ago
|
Blocks: intersection-observer-impl
Assignee | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Needs a test.
Assignee | ||
Comment 3•7 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=1359318#c8.
Assignee | ||
Comment 4•7 years ago
|
||
Don't block enabling web platform test.
Attachment #8861492 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8868636 -
Flags: review?(mstange)
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 5•7 years ago
|
||
Added fix for current tests.
Attachment #8868636 -
Attachment is obsolete: true
Attachment #8868636 -
Flags: review?(mstange)
Attachment #8868714 -
Flags: review?(mstange)
Updated•7 years ago
|
Attachment #8868714 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 6•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=71f368f4ef7558b09a1a9be8e549a62fd63100ab
Assignee | ||
Comment 7•7 years ago
|
||
Another try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc836faaf077f6a395cb0e6291bd1da63282b843
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac88c419e32750d01671b674be68e8906b7ea69c includes thus patch and is looking good.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → tschneider
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07fe4661db8f (intersection-observer) Intersection ratio should be 1.0 for zero-area intersections. r=mstange
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/07fe4661db8f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•