1359323 - stylo: make predefined counter style names static atoms

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Simon Sapin (:SimonSapin)]

* Add strings in kCSSRawPredefinedCounterStyles to the list of static atoms that can be used with the atom!("…") macro in Stylo

* Once https://github.com/servo/servo/pull/16455 has landed, find occurrences of Atom::from("decimal") and replace them with atom!("decimal")

This would avoid a small number of memory allocations.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

> * Once https://github.com/servo/servo/pull/16455 has landed, find occurrences of Atom::from("decimal") and replace them with atom!("decimal")

This has been done. With bug 1328319 lands, all Atom::from("decimal") should have been replaced with atom!("decimal").

> * Add strings in kCSSRawPredefinedCounterStyles to the list of static atoms that can be used with the atom!("…") macro in Stylo

This is probably not necessary. It would likely make parsing counter style name a bit faster since we would not need a second hash table search for atom, but it wouldn't save much memory I suppose.

Comment 2

[Bobby Holley (:bholley)]

Ok. Should this be resolved then?

Comment 3

[Simon Sapin (:SimonSapin)]

I defer to Xidorn’s judgment.