1359359 - FileReaderSync should be able to read from a nsIAsyncInputStream

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

Currently FileReaderSync wants a sync nsIInputStream.
It's not able to deal with the new IPCBlobInputStream.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 0 - IPCBlobInputStream::StreamReady() should be called on the target thread

Right now this is executed on the current thread. This is not compatible with the use of IPCBlobInputStream in sync event loop in workers.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 1 - FileReaderSync should work with nsIAsyncInputStream

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 2 - tests

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8861353 [details] [diff] [review]
part 2 - tests

>+let workerUrl = URL.createObjectURL(new Blob(["(", workerScript.toSource(), ")()"]));
>+let worker = new Worker(workerUrl);
>+worker.onmessage = event => {
>+  ok(event.data.length, "The file has been read");
I would prefer if this tested that the expected data was actually read.

Could you for example read the data asynchronously in the main thread and then compare that the _exactly_ same
data is read synchronously in worker as is asynchronously in main thread. 

With that, r+

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

And please ensure that there are also tests for memory blob reading with workers!
That too is required for the r+.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b65172f39db5
IPCBlobInputStream should execute StreamReady() in the target thread of AsyncWait, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/25c997594daa
FileReaderSync should support nsIAsyncInputStream, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/46389058f13d
Tests for FileReaderSync and IPCBlobInputStream, r=smaug

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b65172f39db5
https://hg.mozilla.org/mozilla-central/rev/25c997594daa
https://hg.mozilla.org/mozilla-central/rev/46389058f13d