Closed Bug 1359363 Opened 4 years ago Closed 2 years ago
Search engine favicon flicker/blinks/flashes after pressing "Show search suggestions" option in "Search" settings
47 bytes, text/x-phabricator-request
|Details | Review|
Environment: Device: Samsung Galaxy Note 4 (Android 5.0.1); Build: Nightly 55.0a1 (2017-04-23); Steps to reproduce: 1. Launch Fennec and go to Menu -> Settings -> Search; 2. Turn on/off Show Search suggestions 3-4 times; 3. Observe the search engines. Expected results: There is a visible flicker when "show search suggestions" are enabled/disabled. Actual result: Enabled/disabled of "show search suggestions" doesn't affect the installed search engines. Notes: Video: https://youtu.be/7GNTFZxA2dA Regression window: Last good build: 03-02 First bad build: 03-03 Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e91de6fb2b3dce9c932428265b0fdb630ea470d7&tochange=9732cd019a8b94c49a275661320c1b742635a3d6
Hardware: ARM → All
tracking-fennec: ? → 55+
Priority: -- → P2
Since this is 55+ for fennec, marking fix-optional for 54.
Wesley, I'm a bit hesitant to track this for 55 given this has been filed 2 months ago and there doesn't seem to be much progress yet. Is this still on track for a fix in early beta55?
I'll track this for 56 for now. The effect sounds minor. If we get a patch we could still uplift to 55.
Very likely the team won't have bandwidth to make it in 55. 56 is more practical.
Looking at this again it seems like a fairly minor regression and I don't think release management needs to track it - we can leave it to the Fennec team to fix when they have time.
[triage] Bulk edit from title: this is a non-critical issue. Please remove priority if you wish this to be re-triaged.
Priority: P2 → P3
3 years ago
Reproducible in the latest version of NIghtly 65.0a1 (2018-10-25) with OnePlus 5T (Android 8.1.0).
Marking fix-optional for 64. We could still take a patch for 65, and if it's verified and doesn't seem risky, could still take fixes for 64 as well.
Happy to take a patch in nightly; if it seems low risk enough please feel free to request uplift to 65 beta.
You need to log in before you can comment on or make changes to this bug.