Open Bug 1359393 Opened 7 years ago Updated 2 years ago

HTMLEditor::NodeIsInlineStatic() returns false when given node is not an inline element

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

People

(Reporter: masayuki, Unassigned)

References

Details

This is really odd behavior if caller checks its result with |!|.

http://searchfox.org/mozilla-central/rev/baf47b352e873d4516d7656186d6d7c7447d3873/editor/libeditor/HTMLEditRules.cpp#7941,7946,7951

> bool
> HTMLEditRules::IsEmptyInline(nsINode& aNode)
> {
>   NS_ENSURE_TRUE(mHTMLEditor, false);
>   RefPtr<HTMLEditor> htmlEditor(mHTMLEditor);
> 
>   if (IsInlineNode(aNode) && htmlEditor->IsContainer(&aNode)) {
>     bool isEmpty = true;
>     htmlEditor->IsEmptyNode(&aNode, &isEmpty);
>     return isEmpty;
>   }
>   return false;
> }
Priority: -- → P3
Summary: HTMLEditRules::IsEmptyInline() returns false when given node is not an inline element → HTMLEditor::NodeIsInlineStatic() returns false when given node is not an inline element
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.