Closed
Bug 1359396
Opened 3 years ago
Closed 2 years ago
HTMLEditRules::IsEmptyBlock() should return bool
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
P3
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
HTMLEditRules::IsEmptyBlock() now returns nserror and then, the result is always true. This behavior is too odd. And a caller, HTMLEditRules::WillInsertBreak(), doesn't check the result. This should just return bool and if it's not a block, should return false.
|
||
Updated•3 years ago
|
status-firefox57:
affected → ---
|
||
Updated•2 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•2 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff9d32266d2db38a3477b0a8af52d6bd2b59824d
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
|
|
||
Comment 3•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8937997 [details] Bug 1359396 - Redesign HTMLEditRules::IsEmptyBlock() https://reviewboard.mozilla.org/r/208682/#review215008
Attachment #8937997 -
Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/39bcda54a789 Redesign HTMLEditRules::IsEmptyBlock() r=m_kato
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/39bcda54a789
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•