Closed Bug 1359396 Opened 3 years ago Closed 2 years ago

HTMLEditRules::IsEmptyBlock() should return bool

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

HTMLEditRules::IsEmptyBlock() now returns nserror and then, the result is always true. This behavior is too odd. And a caller, HTMLEditRules::WillInsertBreak(), doesn't check the result.

This should just return bool and if it's not a block, should return false.
Priority: -- → P3
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Comment on attachment 8937997 [details]
Bug 1359396 - Redesign HTMLEditRules::IsEmptyBlock()

https://reviewboard.mozilla.org/r/208682/#review215008
Attachment #8937997 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/39bcda54a789
Redesign HTMLEditRules::IsEmptyBlock() r=m_kato
https://hg.mozilla.org/mozilla-central/rev/39bcda54a789
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.