1359415 - move threadsafety checks inside nsAutoOwningThread

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nathan Froyd [:froydnj]]

This change moves most of the logic for the threadsafety check into
nsAutoOwningThread, rather than having part of the logic live in
nsAutoOwningThread and part of the logic live in nsDebug.h.  Changing
this also forces us to clean up a couple of places that replicated the
logic that lived in nsDebug.h as well.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move threadsafety checks inside nsAutoOwningThread

I think this is an improvement, WDYT?

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8861419 [details] [diff] [review]
move threadsafety checks inside nsAutoOwningThread

Review of attachment 8861419 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this is a nice cleanup.

::: xpcom/base/nsISupportsImpl.cpp
@@ +30,5 @@
> +#ifdef MOZ_THREAD_SAFETY_OWNERSHIP_CHECKS_SUPPORTED
> +void
> +nsAutoOwningThread::AssertCurrentThreadOwnsMe(const char* msg) const
> +{
> +  if (mThread != PR_GetCurrentThread()) {

Should we MOZ_UNLIKELY this?

::: xpcom/base/nsISupportsImpl.h
@@ +57,5 @@
>  public:
>    nsAutoOwningThread() { mThread = PR_GetCurrentThread(); }
> +
> +  template<int N>
> +  void AssertOwnership(const char (&aMsg)[N]) const

Maybe a comment here that we did it this way to guarantee a string literal is used.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8457e1358dda
move threadsafety checks inside nsAutoOwningThread; r=erahm

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8457e1358dda