1359419 - [geckoview] Add GeckoView.preload(), used to start Gecko before we have a GeckoView

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, enhancement)

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1359419 - Add GeckoView.preload()

Review commit: https://reviewboard.mozilla.org/r/133408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133408/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8861427 [details]
Bug 1359419 - Add GeckoView.preload()

https://reviewboard.mozilla.org/r/133408/#review136354

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java:270
(Diff revision 1)
>  
>          final GeckoViewSettings newSettings = new GeckoViewSettings(settings, getEventDispatcher());
>          init(context, newSettings);
>      }
>  
> -    private void init(final Context context, final GeckoViewSettings settings) {
> +    public static void preload(Context context) {

Can be final.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8861427 [details]
Bug 1359419 - Add GeckoView.preload()

https://reviewboard.mozilla.org/r/133408/#review136436

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java:277
(Diff revision 1)
> +            context.getApplicationContext());
> +
>          if (GeckoAppShell.getApplicationContext() == null) {
>              GeckoAppShell.setApplicationContext(context.getApplicationContext());
>          }
> +        GeckoAppShell.setApplicationContext(context.getApplicationContext());

`setApplicationContext` is called twice here

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a18abb7a8f3
Add GeckoView.preload() r=esawin

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0a18abb7a8f3