Closed
Bug 1359425
Opened 7 years ago
Closed 7 years ago
commonize the Rust feature definitions for gkrust*
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
3.17 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
Having these definitions in two different places is silly, especially when they must be identical. If they ever got out of sync, there would be problems.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8861433 -
Flags: review?(giles)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8861433 [details] [diff] [review] commonize the Rust feature definitions for gkrust* Review of attachment 8861433 [details] [diff] [review]: ----------------------------------------------------------------- Does it make sense to move gkrust-features.mozbuild down a level, into toolkit/library/rust/ since that's where gkrust (and the current feature conditionals) is defined?
Attachment #8861433 -
Flags: review?(giles) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c8884c38a51d commonize the Rust feature definitions for gkrust*; r=rillian
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c8884c38a51d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•