Closed Bug 1359427 Opened 3 years ago Closed 3 years ago

Ignore gecko.log files from VCS

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

I occasionally add gecko.log as part of my patch, often when I’m fixing up patches in code review.  Adding it to .gitignore/.hgignore would solve that problem.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8861441 [details]
Bug 1359427 - Hide top-level gecko.log from VCSes;

https://reviewboard.mozilla.org/r/133432/#review136368

::: .hgignore:36
(Diff revision 1)
>  
>  # Build directories
>  ^obj
>  
> +# gecko.log is generated by various test harnesses
> +^gecko.log

The period needs escaped like elsewhere in this file.

I trust you can do this before landing.
Attachment #8861441 - Flags: review?(gps) → review+
Comment on attachment 8861441 [details]
Bug 1359427 - Hide top-level gecko.log from VCSes;

https://reviewboard.mozilla.org/r/133432/#review136368

> The period needs escaped like elsewhere in this file.
> 
> I trust you can do this before landing.

Well spotted, thanks!
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2454031a4836
Hide top-level gecko.log from VCSes; r=gps
https://hg.mozilla.org/mozilla-central/rev/2454031a4836
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
I'd argue we shouldn't write out a gecko.log in the source directory in the first place.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.