Ignore gecko.log files from VCS

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: ato, Assigned: ato)

Tracking

unspecified
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I occasionally add gecko.log as part of my patch, often when I’m fixing up patches in code review.  Adding it to .gitignore/.hgignore would solve that problem.
(Assignee)

Updated

a year ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8861441 [details]
Bug 1359427 - Hide top-level gecko.log from VCSes;

https://reviewboard.mozilla.org/r/133432/#review136368

::: .hgignore:36
(Diff revision 1)
>  
>  # Build directories
>  ^obj
>  
> +# gecko.log is generated by various test harnesses
> +^gecko.log

The period needs escaped like elsewhere in this file.

I trust you can do this before landing.
Attachment #8861441 - Flags: review?(gps) → review+
(Assignee)

Comment 3

a year ago
mozreview-review-reply
Comment on attachment 8861441 [details]
Bug 1359427 - Hide top-level gecko.log from VCSes;

https://reviewboard.mozilla.org/r/133432/#review136368

> The period needs escaped like elsewhere in this file.
> 
> I trust you can do this before landing.

Well spotted, thanks!
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2454031a4836
Hide top-level gecko.log from VCSes; r=gps

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2454031a4836
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
I'd argue we shouldn't write out a gecko.log in the source directory in the first place.

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.