Closed
Bug 1359429
Opened 7 years ago
Closed 7 years ago
Remove superfluous telemetry probes
Categories
(Firefox :: Session Restore, enhancement)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file)
|
6.16 KB,
patch
|
mikedeboer
:
review+
benjamin
:
feedback+
|
Details | Diff | Splinter Review |
There are telemetry probes that no longer serve a purpose. Let's remove those.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•7 years ago
|
||
Specifically, FX_SESSION_RESTORE_COLLECT_DATA_LONGEST_OP_MS can go because that's exactly the same as FX_SESSION_RESTORE_COLLECT_DATA_MS now. We can remove FX_SESSION_RESTORE_COLLECT_COOKIES_MS because that's just a flat line since bug 912717 landed.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Do we need to ask someone else for the Histograms* changes?
Attachment #8861448 -
Flags: review?(mdeboer)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8861448 [details] [diff] [review] 0001-Bug-1359429-Remove-superfluous-telemetry-probes-r-mi.patch Review of attachment 8861448 [details] [diff] [review]: ----------------------------------------------------------------- For removal of histograms: I don't think so, but not sure.
Attachment #8861448 -
Flags: review?(mdeboer)
Attachment #8861448 -
Flags: review+
Attachment #8861448 -
Flags: feedback?(benjamin)
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8861448 [details] [diff] [review] 0001-Bug-1359429-Remove-superfluous-telemetry-probes-r-mi.patch That's a slightly tough question; if you're sure you're the only team using this data, then you don't need data review to remove probes.
Attachment #8861448 -
Flags: feedback?(benjamin) → feedback+
Pushed by ttaubert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cdd3e10663be Remove superfluous telemetry probes r=mikedeboer f=bsmedberg
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cdd3e10663be
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•