1359450 - Force the use of wmode opaque when Firefox isn't using accelerated compositing

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jim Mathies [:jimm]]

In bug 1340276 we forced wmode=direct for Flash applets that specify wmode=window or do not specify a wmode. The fallback mode for direct is window. 

I'd like to modify this slightly such that in cases where we do not have an accelerated backend (cases where NPNVsupportsAsyncWindowsDXGISurfaceBool returns false) plugin shim code forces wmode=opaque rather than direct. This should prevent flash from falling back on windowed mode in this situation.

Comment 1

[Jim Mathies [:jimm]]

Actually, we don't need to force opaque mode because Flash forces opaque internally for these cases when switching windowed mode to async bitmap rendering.

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a02c93ed5bcf
Use Flash default wmode handling when Firefox can't support async accelerated rendering. Avoid forcing direct mode in these cases which falls back on windowed layout. r=aklotz

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a02c93ed5bcf

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8861488 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]:
none. this is a configuration change in the way we handle flash window modes.
[User impact if declined]:
more use of windowed mode in release than we'd like.
[Is this code covered by automated tests?]:
no.
[Has the fix been verified in Nightly?]:
yes.
[Needs manual test from QE? If yes, steps to reproduce]: 
sv plans to do a full round of testing of the overall feature in beta starting next week.
[List of other uplifts needed for the feature/fix]:
none.
[Is the change risky?]:
no.
[Why is the change risky/not risky?]:
well understood change to our rewrite rules for flash wmodes.
[String changes made/needed]:
none.

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8861488 [details] [diff] [review]
patch

Fix a wmode handling issue. Beta54+. Should be in 54 beta 4.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f644e615b15e