In task-creator, adjust *all* timestamps relative to created

RESOLVED FIXED

Status

Taskcluster
Tools
RESOLVED FIXED
8 months ago
2 months ago

People

(Reporter: dustin, Assigned: hassan)

Tracking

Details

(Reporter)

Description

8 months ago
The "update timestamps" button should:

* subtract task.created from the current time
* add that value to everything that looks like a JSON timestamp in the task definition
(Reporter)

Comment 1

7 months ago
https://github.com/taskcluster/taskcluster-tools/pull/213

Comment 2

7 months ago
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/b74c62a62e50546c9be8ae4ce55915d647a06c2c
Bug 1359468: update task timestamps relative to created time (#213)

This should catch all timestamps in a task definition, and will keep
them constant relative to the created time.
(Reporter)

Updated

7 months ago
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
(Reporter)

Comment 3

5 months ago
This seems to have been reverted, perhaps in the Great Tools Rewrite..
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 4

5 months ago
STR: open task creator, adjust deadline to a year after the created date, click "update timestamps", see that it goes back to one hour after created.

Comment 5

5 months ago
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/e858f454e1ec841a5c003a73ced58a828a169273
Merge pull request #254 from helfi92/adjust-timestamps

Bug 1359468 - Adjust all timestamps relative to created
(Reporter)

Comment 6

5 months ago
:dmose, can you verify this fixed things for you?  Such a little bug, so frustrating.
Flags: needinfo?(dmose)
(Reporter)

Updated

5 months ago
Assignee: dustin → helfi92

Comment 7

5 months ago
So when I do "Actions"->"Edit Task" now I don't get any created or deadline field copied in, could that have been this bug breaking?

Once I enter a created/deadline field manually then the "update timestamps" seems to work fine.
Flags: needinfo?(helfi92)
Flags: needinfo?(dustin)
(Reporter)

Comment 8

5 months ago
https://github.com/taskcluster/taskcluster-tools/pull/256 should fix that
Flags: needinfo?(helfi92)
Flags: needinfo?(dustin)
Flags: needinfo?(bugspam.Callek)

Comment 9

5 months ago
confirmed (these keys are in a different place than I remember them, but the key order doesn't matter and arguably makes more sense where they are, so \o/ )
Flags: needinfo?(bugspam.Callek)
(Assignee)

Updated

5 months ago
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago5 months ago
Resolution: --- → FIXED

Updated

2 months ago
Flags: needinfo?(dmose)
You need to log in before you can comment on or make changes to this bug.