1359471 - Disk Space cache setting doesn't survive restart - browser.cache.disk.smart_size.enabled missing from the panel

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[L.A.R. Grizzly]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170413192749

Steps to reproduce:

Setting Disk Space to 50mb doesn't stick.


Actual results:

When TB is reopened, Disk Space setting returns to 350mb. Placing "user_pref("browser.cache.disk.capacity", 51200);" into my user.js file has no effect. Checking the actual disk space results in more than 50mb used, so it's not a UI glitch.


Expected results:

Setting Disk Space to 50mb should stick.

Comment 1

[Wayne Mery (:wsmwk)]

I see this also in 53.0b2. Do you see anything in tools > error console?

Steps:
- open options and change cache setting
- close options
- reopen options - the changed value is there
- restart thunderbird

changed value isn't there

Comment 2

[Jorg K (CEST = GMT+2)]

Oh, it looks like we're missing the "Override automatic cache management" option that FF has.
We need to add browser.cache.disk.smart_size.enabled to the panel.

Richard, could you take this bug, please.

Comment 3

[L.A.R. Grizzly]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #1)
> I see this also in 53.0b2. Do you see anything in tools > error console?
> 
> Steps:
> - open options and change cache setting
> - close options
> - reopen options - the changed value is there
> - restart thunderbird
> 
> changed value isn't there

This is exactly what I'm experiencing. I have items in the error console, but I'm at a loss how to interpret what I'm seeing.

Comment 4

[L.A.R. Grizzly]

(In reply to Jorg K (GMT+2) from comment #2)
> Oh, it looks like we're missing the "Override automatic cache management"
> option that FF has.
> We need to add browser.cache.disk.smart_size.enabled to the panel.
> 
> Richard, could you take this bug, please.

Thanks for the tip. Toggling browser.cache.disk.smart_size.enabled to false seems to have alleviated the problem (at least in the UI). I'll need to wait a while to see if the cache size is physically kept to 50mb.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug1359471.patch

Something like this?

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #5)
> Something like this?
I think so. You copied all the relevant bits from FF and it works!

If used "in-content", the "v" clashes with "View". And maybe you can explain to me why the "a" for "Compact" doesn't work. Of course that's not part of this bug, but just out of interest.

Comment 7

[Richard Marti (:Paenglab)]

"v" works directly for me and the "View" isn't touched. In In-content you have to use SHIFT additionally to the normal accesskeys. Here also ALT SHIFT v.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 8861579 [details] [diff] [review]
Bug1359471.patch

Thanks, using <shift> works. I can land this now with another bug I have.

Comment 9

[Richard Marti (:Paenglab)]

Okay, I don't set c-n.

Comment 10

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/6050971cbdcd387cbe97d8e43c157a119341b221

Due to the string changes I can't backport this to TB 52 ESR, sorry.

Comment 11

[Onno Ekker [:nONoNonO UTC+1]]

https://hg.mozilla.org/l10n-central/nl/rev/cb9bacfe1515c9f82704680e8745ff16b65c9efb
Bug 1359471 - Add a checkbox to disable the cache smart size