If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enable eslint on mobile/android/tests

RESOLVED FIXED in Firefox 55

Status

Testing
Lint
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
+++ This bug was initially created as a clone of Bug #1357557 +++
(Assignee)

Comment 1

5 months ago
Created attachment 8861563 [details] [diff] [review]
enable eslint on mobile/android/tests

I'm pretty sure I haven't broken any tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d5536a9fd5a79bbc2b30d22f1033cae7918c84c


:standard8 -- This is new ground for me; I'd appreciate lots of feedback.

:snorp -- Any concerns with linting mobile/android/tests?
Attachment #8861563 - Flags: review?(standard8)
Attachment #8861563 - Flags: review?(snorp)
Comment on attachment 8861563 [details] [diff] [review]
enable eslint on mobile/android/tests

Review of attachment 8861563 [details] [diff] [review]:
-----------------------------------------------------------------

Looking good. Please can you also remove the mobile/android/tests/.eslintrc file, as that isn't necessary (the various *-test configs define those for us).

::: mobile/android/tests/.eslintrc.js
@@ +1,5 @@
> +"use strict";
> +
> +module.exports = {
> +  "extends": [
> +    "plugin:mozilla/mochitest-test"

There's no simple mochitests in the test directory as far as I can tell, so you shouldn't need this file.
Attachment #8861563 - Flags: review?(standard8) → review+
Attachment #8861563 - Flags: review?(snorp) → review+

Comment 3

5 months ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b4d43ed9b7f
Enable eslint on mobile/android/tests; r=standard8,snorp

Comment 4

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7b4d43ed9b7f
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.