Closed Bug 1359548 Opened 3 years ago Closed 3 years ago

More incorrectly specified ABIs in js-ctypes declarations

Categories

(Firefox :: Migration, defect)

45 Branch
x86
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox-esr45 --- wontfix
firefox-esr52 --- wontfix
firefox53 --- wontfix
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

(Keywords: regression, Whiteboard: [ctypes.abi])

Attachments

(1 file)

No description provided.
Comment on attachment 8861564 [details]
Bug 1359548: Fix incorrectly specified ABIs in js-ctypes declaration in migration code;

https://reviewboard.mozilla.org/r/133528/#review136420
Attachment #8861564 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67d17cae23bb
Fix incorrectly specified ABIs in js-ctypes declaration in migration code; r=Gijs
Comment on attachment 8861564 [details]
Bug 1359548: Fix incorrectly specified ABIs in js-ctypes declaration in migration code;

Approval Request Comment
[Feature/Bug causing the regression]: JS-ctypes code in profile migration
[User impact if declined]: Potential for crashes and/or data corruption
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Trivial patch
[String changes made/needed]: None
Attachment #8861564 - Flags: approval-mozilla-beta?
Comment on attachment 8861564 [details]
Bug 1359548: Fix incorrectly specified ABIs in js-ctypes declaration in migration code;

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a stability issue
User impact if declined: Potential for crashing / data corruption
Fix Landed on Version: 55, 54 requested
Risk to taking this patch (and alternatives if risky): None. Trivial patch
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8861564 - Flags: approval-mozilla-esr52?
Blocks: 1229076
Keywords: regression
Version: unspecified → 45 Branch
https://hg.mozilla.org/mozilla-central/rev/67d17cae23bb
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8861564 [details]
Bug 1359548: Fix incorrectly specified ABIs in js-ctypes declaration in migration code;

Fix a potential crash/data corruption. Beta54+. Should be in 54 beta 3.
Attachment #8861564 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8861564 [details]
Bug 1359548: Fix incorrectly specified ABIs in js-ctypes declaration in migration code;

Cancelling ESR52 request. I have looked at the libffi code and there is no chance of crashing given the way it is implemented.
Attachment #8861564 - Flags: approval-mozilla-esr52?
(In reply to Aaron Klotz [:aklotz] (a11y work receiving priority right now) from comment #4)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Aaron's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.