1359549 - "Retrigger success" shown even if buildapi part of retrigger not completed

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect)

Description

[Ed Morley [:emorley]]

1) Start a new browser session that hasn't yet submitted an HTTP auth to buildapi
2) Load https://treeherder.mozilla.org/
3) Sign in via TC auth
4) Select a buildbot job
5) Press retrigger, but leave the password prompt open
6) Watch for notifications shown in the background
7) Press cancel on the HTTP auth prompt
8) Watch for notifications shown in the main UI

Expected:
* Retrigger notification message is not shown until all parts of the retrigger have occurred (eg treeherder's API being pinged and also one of: taskcluster API request made or buildapi request made).
* In addition, if HTTP auth cancelled or fails (eg incorrect password, network issue, non-HTTP 200 response) then a failure message shown.

Actual:
* At step #6 a "Retrigger success" message can be seen in the background, even though the password hasn't yet been entered for HTTP auth. 
* At step #8, no further message is shown indicating that the retrigger was not successful.


This caused confusion in bug 1269281.

Comment 1

[Ed Morley [:emorley]]

Wontfix since buildbot EOL.