1359659 - When switching from custom tabs to Fennec, the dynamic toolbar can get permanently pinned

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P3)

Description

[Randall Barker [:rbarker]]

If the toolbar gets pinned in a custom tab and does not get unpinned before switching to fennec, they dynamic toolbar get get permanently pinned.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1359659 - Ensure the complete pinned state is sent from the UI thread to the compositor

Review commit: https://reviewboard.mozilla.org/r/133702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133702/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8861717 [details]
Bug 1359659 - Ensure the complete pinned state is sent from the UI thread to the compositor

https://reviewboard.mozilla.org/r/133702/#review136612

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/DynamicToolbarAnimator.java:164
(Diff revision 1)
>                  mCompositor.sendToolbarAnimatorMessage(LayerView.REQUEST_SHOW_TOOLBAR_IMMEDIATELY);
>              } else {
>                  mCompositor.sendToolbarAnimatorMessage(LayerView.REQUEST_HIDE_TOOLBAR_IMMEDIATELY);
>              }
> -            for (PinReason reason : pinFlags) {
> -              mCompositor.setPinned(true, reason.mValue);
> +            for (PinReason reason : PinReason.values()) {
> +              mCompositor.setPinned(mPinFlags.contains(reason), reason.mValue);

Can you also rename `mValue` in `PinReason` to `value`, since it's a public member?

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8861717 [details]
Bug 1359659 - Ensure the complete pinned state is sent from the UI thread to the compositor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133702/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/774240b19c63
Ensure the complete pinned state is sent from the UI thread to the compositor r=jchen

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/774240b19c63