Preferences::GetBool(PREF_ALWAYS_INCLUDE_RUBY) should use AddBoolVarCache

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks 1 bug)

55 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

When profiling nsDocumentEncoder::EncodeToStringWithMaxLength for text/plain, 25% is Preferences::GetBool into nsPlainTextSerializer::Init.  So we should use AddBoolVarCache for it.
Assignee: nobody → m_kato
Blocks: 1346723
Comment on attachment 8862377 [details]
Bug 1359707 - Preferences::GetBool(PREF_ALWAYS_INCLUDE_RUBY) should use AddBoolVarCache.

https://reviewboard.mozilla.org/r/134336/#review137260

::: commit-message-0b77e:3
(Diff revision 1)
> +Bug 1359707 - Preferences::GetBool(PREF_ALWAYS_INCLUDE_RUBY) should use AddBoolVarCache. r?smaug
> +
> +When profiling nsDocumentEncoder::EncodeToStringWithMaxLength for text/plain, 25% is Preferences::GetBool into nsPlainTextSerializer::Init.  So we should use AddBoolVarCache for it.

interesting. 25% is horrible
Attachment #8862377 - Flags: review?(bugs) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/dce18d478087
Preferences::GetBool(PREF_ALWAYS_INCLUDE_RUBY) should use AddBoolVarCache. r=smaug
https://hg.mozilla.org/mozilla-central/rev/dce18d478087
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.