If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove unnecessary SetIsPaused() calls

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
We pause/unpause the profiler before/after some streaming operations. But these
pause/unpause pairs occur with gPSMutex locked, and ActivePS::IsPaused() also
requires that gPSMutex be locked. Therefore these pause/unpause pairs cannot
be observed, and so this patch removes them.
(Assignee)

Comment 1

5 months ago
Created attachment 8861783 [details] [diff] [review]
Remove unnecessary SetIsPaused() calls
Attachment #8861783 - Flags: review?(mstange)
Attachment #8861783 - Flags: review?(mstange) → review+
(Assignee)

Comment 2

5 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b70d46e776013af3ee53f055679b92286649bd0
Bug 1359717 - Remove unnecessary SetIsPaused() calls. r=mstange.
https://hg.mozilla.org/mozilla-central/rev/4b70d46e7760
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.