1359738 - Add push_yuv_image() interface in WR binding

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Expose wr push_yuv_image() interface to gecko.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Add push_yuv_image() in WR binding.

Please check [1] for webrender_ffi_generated.h updates.

[1]
https://dxr.mozilla.org/mozilla-central/rev/f229b7e5d91eb70d23d3e31db7caff9d69a2ef04/gfx/webrender_bindings/webrender_ffi_generated.h#7

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba4e68586f6fb298aef4d4ce0f4eeedb51c2b62c

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/8ff62d84dc10
Add push_yuv_image() in WR binding.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/8ff62d84dc10

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi kats,
Sorry, I forget to set the reviewer on that commit.
Both of these commits doesn't contain the reviewer info.
https://hg.mozilla.org/projects/graphics/rev/8ff62d84dc10
https://hg.mozilla.org/mozilla-central/rev/8ff62d84dc10
How could I fix that?

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Personally, I would just leave it as-is. If it hadn't been merged to m-c, it might have been worth backing out and relanding with the reviewer added (in a DONTBUILD push since this has already been tested), but since it's already on m-c, it might as well just stay. It's not hurting anything by not being there; people can just look in the bug and see the r+ if they really need to find it.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Yeah I would just leave it.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

How did you generate the changes to webrender_ffi_generated.h in this patch? The WrYuvColorSpace enum in particular.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #8)
> How did you generate the changes to webrender_ffi_generated.h in this patch?
> The WrYuvColorSpace enum in particular.

Oh, never mind. I screwed up something on my end..