Closed Bug 1359738 Opened 4 years ago Closed 4 years ago

Add push_yuv_image() interface in WR binding

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jerry, Assigned: jerry)

References

Details

Attachments

(1 file)

Expose wr push_yuv_image() interface to gecko.
Attachment #8861828 - Flags: review?(nical.bugzilla) → review+
Pushed by hshih@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8ff62d84dc10
Add push_yuv_image() in WR binding.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Hi kats,
Sorry, I forget to set the reviewer on that commit.
Both of these commits doesn't contain the reviewer info.
https://hg.mozilla.org/projects/graphics/rev/8ff62d84dc10
https://hg.mozilla.org/mozilla-central/rev/8ff62d84dc10
How could I fix that?
Flags: needinfo?(bugmail)
Personally, I would just leave it as-is. If it hadn't been merged to m-c, it might have been worth backing out and relanding with the reviewer added (in a DONTBUILD push since this has already been tested), but since it's already on m-c, it might as well just stay. It's not hurting anything by not being there; people can just look in the bug and see the r+ if they really need to find it.
Yeah I would just leave it.
Flags: needinfo?(bugmail)
How did you generate the changes to webrender_ffi_generated.h in this patch? The WrYuvColorSpace enum in particular.
Flags: needinfo?(hshih)
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #8)
> How did you generate the changes to webrender_ffi_generated.h in this patch?
> The WrYuvColorSpace enum in particular.

Oh, never mind. I screwed up something on my end..
Flags: needinfo?(hshih)
You need to log in before you can comment on or make changes to this bug.