1359746 - [Regression] PageControl button does not dissapear when there is only one page of top sites

Status: VERIFIED FIXED

(Firefox for iOS :: Build & Test, defect, P1)

Description

[Isabel Rios[:isabel_rios]]

XCUITest covering this is failing
testActivityStreamPages()

Also is reproducible on a device with latest master bb 2869

There should have been a regression between this two commits:
Passing:8c583626f398b84a39a925f96e97a68091115312

Failing:6c1e026362a425cef6c7d04a4d74440f9940ec9a

Steps: 
1-Go to a web site and tap on back
2-Repeat this 4 times so the page control button appears to go to the second top sites page
3-On the first top sites page, long tap on one of them and remove it

Expected:
Since there are only 8 top sites, and all of them fit in one page, the control page button dissapears.

Actual:
The page control button does not dissapear.  Nothing happens when tapping on it.
Closing and opening the app fixes this, also going to a top site and back to this view make it dissapear.

Please see behaviour here: https://youtu.be/iEPKYAP8IeQ

Comment 1

[Farhan Patel [:farhan]]

I cant reproduce this on 
c4b9db32ff30383071cefef3ff81f988c482957f

Are you still seeing it?

Comment 2

[Isabel Rios[:isabel_rios]]

I can reproduce with that commit and with the master latest one too (5549dc9e97c17337e96508ffa9d802bd11bbcc89). 

The test is still failing too on latest builds in bb.

Comment 3

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 4

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/e0d8f1f2b38ab560302df9e4232116f3723754bf