1359800 - Refactor some sweeping logic

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Jon Coppeard (:jonco)]

A couple of minor refactorings.

Firstly, we should be calling IsAboutToBeFinalized in sweeping rather than checking mark bits (either directly or via IsMarked).

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1359800-use-is-about-to-be-finalized

As above.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bug1359800-check-incremental-in-is-marked

Secondly, IsMarked should report cells allocated during incremental marking/sweeping as marked.  Then we can remove this extra check in a few places.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8861937 [details] [diff] [review]
bug1359800-check-incremental-in-is-marked

Review of attachment 8861937 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Marking.cpp
@@ +3088,4 @@
>          *thingp = Forwarded(*thingp);
> +        return true;
> +    }
> +    TenuredCell& thing = (*thingp)->asTenured();

Move this up and reuse it for the zone calculation. You could even get rid of the IsInsideNursery assert if you like, since it's implied by asTenured(), but keep it if you think it's more clear this way.

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8861936 [details] [diff] [review]
bug1359800-use-is-about-to-be-finalized

Review of attachment 8861936 [details] [diff] [review]:
-----------------------------------------------------------------

Don't these patches need to land together? Otherwise this one would lose the allocated during incremental check.

Comment 5

[Jon Coppeard (:jonco)]

(In reply to Steve Fink [:sfink] [:s:] from comment #4)
Nope, IsAboutToBeFinalized already does the allocated during incremental check.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95d2d6bf646d
Use IsAboutToBeFinalized rather than marking state directly during sweeping r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/af2b7f5b3ab5
Check allocatedDuringIncremental flag in IsMarked functions r=sfink

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95d2d6bf646d
https://hg.mozilla.org/mozilla-central/rev/af2b7f5b3ab5