1359822 - Match standard for colSpan/rowSpan

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

After a disproportionately large amount of discussion, testing, and negotiating, HTML finally standardizes proper behavior of colSpan and rowSpan:

https://github.com/whatwg/html/issues/1198
https://github.com/whatwg/html/pull/1993
https://github.com/w3c/web-platform-tests/pull/4115

We should match the spec.  The main thing is that getting the .rowSpan and .colSpan IDL properties will now return the actual clamped value that we use, which is nice.  There might be other small changes as well, to be documented in the commit message.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Bug 1359822 - Match standard for colSpan/rowSpan

Previously, the spec for these attributes didn't match implementations
at all, and that was just fixed:
<https://github.com/whatwg/html/issues/1198>.  There are two
differences to our previous implementation:

1) The IDL property should be set as an unsigned int, not signed.  This
was just a bug.

2) When parsing the IDL property, the value is now clamped to the
minimum/maximum value instead of being set to 1.  Negative values still
get set to 1 instead of 0, even for rowSpan which allows 0 as a value.

The test changes are copied from the wpt test submitted upstream.  An
additional rendering test using getBoundingClientRect() is also accepted
upstream: https://github.com/w3c/web-platform-tests/pull/4115

Review commit: https://reviewboard.mozilla.org/r/134046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134046/

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Note: this is my last day of work for a few months, so I might not be able to make any fixes to get the patch landed.  If someone else wants to take it over, please do.

Comment 3

[:Nika Layzell (on leave)]

Comment on attachment 8862078 [details]
Bug 1359822 - Match standard for colSpan/rowSpan

https://reviewboard.mozilla.org/r/134046/#review136994

LGTM

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f3f10eb4516e -d c81d8164fe03: rebasing 392024:f3f10eb4516e "Bug 1359822 - Match standard for colSpan/rowSpan r=mystor" (tip)
merging dom/base/nsContentUtils.cpp
merging dom/base/nsContentUtils.h
warning: conflicts while merging dom/base/nsContentUtils.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Unfortunately, I don't have a development environment set up right now.  Are you by any chance able to resolve the merge conflict and land this, or find someone who can?  If not, I'll land it when I get back on August 2 or so.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b98c909414
Match standard for colSpan/rowSpan, r=mystor

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3b98c909414