Closed Bug 1359822 Opened 3 years ago Closed 3 years ago
Match standard for col
After a disproportionately large amount of discussion, testing, and negotiating, HTML finally standardizes proper behavior of colSpan and rowSpan: https://github.com/whatwg/html/issues/1198 https://github.com/whatwg/html/pull/1993 https://github.com/w3c/web-platform-tests/pull/4115 We should match the spec. The main thing is that getting the .rowSpan and .colSpan IDL properties will now return the actual clamped value that we use, which is nice. There might be other small changes as well, to be documented in the commit message.
Attachment #8862078 - Flags: review?(michael)
Note: this is my last day of work for a few months, so I might not be able to make any fixes to get the patch landed. If someone else wants to take it over, please do.
Comment on attachment 8862078 [details] Bug 1359822 - Match standard for colSpan/rowSpan https://reviewboard.mozilla.org/r/134046/#review136994 LGTM
Attachment #8862078 - Flags: review?(michael) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s f3f10eb4516e -d c81d8164fe03: rebasing 392024:f3f10eb4516e "Bug 1359822 - Match standard for colSpan/rowSpan r=mystor" (tip) merging dom/base/nsContentUtils.cpp merging dom/base/nsContentUtils.h warning: conflicts while merging dom/base/nsContentUtils.cpp! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Unfortunately, I don't have a development environment set up right now. Are you by any chance able to resolve the merge conflict and land this, or find someone who can? If not, I'll land it when I get back on August 2 or so.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b98c909414 Match standard for colSpan/rowSpan, r=mystor
You need to log in before you can comment on or make changes to this bug.