Closed Bug 1359857 Opened 4 years ago Closed 4 years ago

Include BidiDataProperty (when present) in the DumpFrameTree() output for debugging

Categories

(Core :: Layout, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(1 file)

While investigating/debugging in bug 1358275, I found it really helpful to make DumpFrameTree() output include details of the BidiDataProperty that is stored on each frame.

I suggest we should include this in the (#ifdef DEBUG-guarded) code we have in the tree, so that it'll be available whenever investigating frame trees in a debug build (rather than needing to maintain it as a local patch).
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8862007 [details] [diff] [review]
For frames that have a BidiDataProperty, include this in the debugging info printed by ListGeneric

Review of attachment 8862007 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8862007 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2318d492b17f539d7e9ba8b2417f6b46c3664493
Bug 1359857 - For frames that have a BidiDataProperty, include this in the debugging info printed by ListGeneric. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/2318d492b17f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.