135989 - [SEEN] Seen needs to be more intelligent

Status: RESOLVED INACTIVE

(Webtools Graveyard :: Mozbot, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

In the (fictional) case of:

12:00 <bbaetz> foo
12:01 -- bbaetz is now known as bbaetz_away
12:59 <bbaetz_away> bar
13:00 -- bbaetz_away is now known as bbaetz

The last times that bbaetz and bbaetz_away were seen should both be 13:00.


Actual:

<caillon> botbot seen bbaetz?
<botbot> bbaetz was last seen 14 hours, 53 minutes and 35 seconds ago, changing
nick to bbaetz_away.
<caillon> botbot seen bbaetz_away?
<botbot> bbaetz_away was last seen 11 hours, 46 minutes and 8 seconds ago,
changing nick to bbaetz.

Expected:

<caillon> botbot seen bbaetz?
<botbot> bbaetz was last seen 11 hours, 46 minutes and 8 seconds ago, changing
nick from bbaetz_away.
<caillon> botbot seen bbaetz_away?
<botbot> bbaetz_away was last seen 11 hours, 46 minutes and 8 seconds ago,
changing nick to bbaetz.

Comment 1

[Hixie (not reading bugmail)]

I was considering removing the nick part of seen altogether:

04:25:37 --> NeilOfDoom (~[e-mail]) has joined #buncs
04:25:38 --- Q gives channel operator status to NeilOfDoom
04:27:28 <-- NeilODoom has quit (Ping timeout for NeilODoom)
04:27:28 --- NeilOfDoom is now known as NeilODoom
04:55:49 --> NeilOfDoom ([e-mail]) has joined #buncs
04:55:49 --- Q gives channel operator status to NeilOfDoom
04:59:02 <-- NeilODoom has quit (Ping timeout for NeilODoom)
04:59:03 --- NeilOfDoom is now known as NeilODoom

Comment 2

[[e-mail]]

IMHO !seen should report the last message and any subsequent network action e.g.
Neil was last seen <time> saying "Hixie!"
Neil was last seen <time> saying "Hixie!" before leaving (Ping Timeout: 180s)
Neil was last seen <time> saying "Hixie!" before changing nick to NeilCommenting

I'm not sure whether joining or changing nick from events should count e.g.
Neil was last seen <time> joining #mozilla
Neil was last seen <time> changing nick from NeilAway
Neil was last seen <time> joining #mozilla before leaving (Ping Timeout: 180s)
Neil was last seen <time> joining #mozilla before changing nick to NeilAway

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I just ran into this too.  Recording changing from events seems like it should
be easy...

Comment 4

[Hixie (not reading bugmail)]

*** Bug 138896 has been marked as a duplicate of this bug. ***

Comment 5

[Hixie (not reading bugmail)]

"foo was last seen saying 'bla' in #bar 3 days ago, before changing nick to
foo_bar 2 days ago and finally quitting (ok brb) yesterday."


12:00 <bbaetz> foo
12:01 -- bbaetz is now known as bbaetz_away
12:59 <bbaetz_away> bar
13:00 -- bbaetz_away is now known as bbaetz

"bbaetz was last seen changing nick to bbaetz_away 59 minutes ago, saying 'bar'
in #mozilla 1 minute ago, and changing nick back to bbaetz just now."
"bbaetz_away was last seen saying 'bar' in #mozilla 1 minute ago, before
changing nick to 'bbaetz' just now."


02:00:00 <NeilODoom> hi
...
04:25:37 --> NeilOfDoom (~[e-mail]) has joined #buncs
04:25:38 --- Q gives channel operator status to NeilOfDoom
04:27:28 <-- NeilODoom has quit (Ping timeout for NeilODoom)
04:27:28 --- NeilOfDoom is now known as NeilODoom
04:55:49 --> NeilOfDoom ([e-mail]) has joined #buncs
04:55:49 --- Q gives channel operator status to NeilOfDoom
04:59:02 <-- NeilODoom has quit (Ping timeout for NeilODoom)
04:59:03 --- NeilOfDoom is now known as NeilODoom

"NeilOfDoom was last seen connecting 4 minutes ago before changing nick to
NeilODoom just now. NeilODoom was last seen saying 'hi' 3 hours ago."
"NeilODoom was last seen saying 'hi' 3 hours ago, before disconnecting 1 minute
ago (Ping timeout for NeilODoom) and then changing nick from NeilOfDoom back to
NeilODoom."


[11:59:57] <caillon> ok, brb
[12:00:00] --- caillon is now known as caillon_away
...
[15:00:00] <caillon_away> eek, my house is on fire!!!  I better go put it out.
[15:00:02] <-- caillon_away has quit (this isn't going in a bug report is it?)
..
[20:00:00] <IRCMonkey> botbot: seen caillon?

"caillon was last seen changing nick to caillon_away 8 hours ago, before saying
'eek my house is on fire!!!  I better go put it out.' 5 hours ago, then quitting
(this isn't going in a bug report is it?)."


Basically:
   get the list of things that the nick has done
      saying             $msg   $channel   $ago
      connecting                           $ago
      disconnecting      $quit             $ago
      changing nick to   $newnick          $ago
      changing nick from $oldnick          $ago
   
   start with "$nick was last seen"
   then add the oldest of:
      saying '$text' in #channel
      changing nick to $newnick
      changing nick from $oldnick back to $nick
      connecting
      quitting ($quit)
   ...and perform some magic to get the relevant ones and follow nick changes.
   then append $ago
   then while there is more:
      if the $ago is different, 
         if it's the last line, append 'and finally'
         else append ', before'
         then append the appropriate lines from above, followed by $ago,
      else, append ', then' and the appropriate line from above.
   then append '.'
   If the new nick is different from the original nick and the new nick has
   said something more recently than the most recent "saying" line used, then
   append " $newnick was last seen saying '$text' in $channel $ago."


But:

00:00 foo is now known as |
00:01 <|> test1
00:02 | is now known as foo
00:03 bar is now known as |
00:04 <|> test2
00:05 | is now known as bar

foo was last seen changing nick to | 10 minutes ago, before saying 'test2' in
#test 6 minutes ago and finally changing nick to bar 5 minutes ago.

This need some more thought. Any ideas?

Comment 6

[Hixie (not reading bugmail)]

Err, the line "...and perform some magic to get the relevant ones and follow
nick changes." was supposed to go higher up (in the blank line, in fact).

Comment 7

[Wolf [:wolf]]

Resetting to new default owner.

Comment 8

[:glob ✱]

Mozbot/Firebot is in maintenance-only mode; no further changes are planned.