Closed Bug 1359984 Opened 7 years ago Closed 7 years ago

mobile bookmarks not showing up in sidebar search

Categories

(Firefox :: Bookmarks & History, defect)

55 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: lazymonkey, Assigned: tcsc)

References

Details

(Keywords: regressionwindow-wanted)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170426030329

Steps to reproduce:

1) setup sync on desktop and android.
2) add a bookmark on android (it goes into the mobile folder) and sync to desktop
3) on desktop open bookmarks sidebar with ctrl + b
4) look in mobile folder and make sure there is the new added bookmakr
5) in the top search field type part of the name of the bookmark in mobile folder


Actual results:

no bookmark is showed in left sidebar


Expected results:

the bookmark from mobile folder should be visible in sidebar
Component: Untriaged → Sync
This works for us. Can you please install the https://addons.mozilla.org/en-US/firefox/addon/about-sync/ addon and check if the bookmark is on the server, and if so, whether it reports any validation errors for bookmarks?
Flags: needinfo?(tortino)
Ah, Thom pointed out that I misread the bug - the bookmark is in the mobile folder, but doing a search doesn't find entries in that folder. It seems likely that this is a regression.
Status: UNCONFIRMED → NEW
Component: Sync → Bookmarks & History
Ever confirmed: true
Flags: needinfo?(tortino)
Summary: mobile bookmark not found in sidebar → mobile bookmarks not showing up in sidebar search
Additional note: search doesn't work in library bookmarks too (ctrl + shift + b and then use search filter)
Comment on attachment 8862245 [details]
Bug 1359984 - Add mobile root to places organizer and bookmark sidebar search panels.

https://reviewboard.mozilla.org/r/134196/#review137308

For the Library you should modify:
http://searchfox.org/mozilla-central/rev/ce5ccb6a8ca803271c946ccb8b43b7e7d8b64e7a/browser/components/places/content/places.js#946
and
http://searchfox.org/mozilla-central/source/browser/components/places/content/places.js#760
(this is quite legacy code, I'm sure it's horrible and could be written better, just not worth it for now)
Assignee: nobody → tchiovoloni
Status: NEW → ASSIGNED
Comment on attachment 8862245 [details]
Bug 1359984 - Add mobile root to places organizer and bookmark sidebar search panels.

https://reviewboard.mozilla.org/r/134196/#review137602
Attachment #8862245 - Flags: review?(mak77) → review+
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9dc1bb192c8
Add mobile root to places organizer and bookmark sidebar search panels. r=mak
https://hg.mozilla.org/mozilla-central/rev/d9dc1bb192c8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: