Closed Bug 1359988 Opened 4 years ago Closed 4 years ago

Remove mozharness references to b2g

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

There are still some references to b2g in mozharness. Let's nuke them.
Comment on attachment 8862160 [details]
Bug 1359988 - Remove gaia scripts and configs from mozharness;

https://reviewboard.mozilla.org/r/134142/#review137436

Huh, I never knew there was a 'users' directory in mozharness. Maybe we can remove users/sfink too?
Attachment #8862160 - Flags: review?(mshal) → review+
Comment on attachment 8862161 [details]
Bug 1359988 - Remove mozharness docs related to gaia;

https://reviewboard.mozilla.org/r/134144/#review137440
Attachment #8862161 - Flags: review?(mshal) → review+
Comment on attachment 8862162 [details]
Bug 1359988 - Remove references to gaia in mozharness;

https://reviewboard.mozilla.org/r/134146/#review137442
Attachment #8862162 - Flags: review?(mshal) → review+
Comment on attachment 8862163 [details]
Bug 1359988 - Remove mozharness configs for multi locale b2g builds;

https://reviewboard.mozilla.org/r/134148/#review137444
Attachment #8862163 - Flags: review?(mshal) → review+
Comment on attachment 8862164 [details]
Bug 1359988 - Remove spidermonkey b2g build script;

https://reviewboard.mozilla.org/r/134150/#review137446
Attachment #8862164 - Flags: review?(mshal) → review+
Attachment #8862165 - Flags: review?(mshal) → review+
All looks good to me. I still see some references to b2g when grepping:

./mozharness/mozilla/l10n/multi_locale_build.py:        Now that we have a different approach for B2G multilocale,
./mozharness/mozilla/testing/unittest.py:            url = 'https://hg.mozilla.org/%s/raw-file/%s/b2g/test/emulator.manifest' % (
./mozharness/mozilla/testing/mozpool.py:    def retrieve_android_device(self, b2gbase):
./mozharness/mozilla/testing/mozpool.py:                               b2gbase=b2gbase, pxe_config=None, duration=duration)
./mozharness/mozilla/testing/errors.py:    {'substr': 'Fatal signal 11 (SIGSEGV)', 'level': ERROR, 'explanation': 'This usually indicates the B2G process has crashed'},
./mozharness/mozilla/testing/errors.py:    {'substr': 'Fatal signal 7 (SIGBUS)', 'level': ERROR, 'explanation': 'This usually indicates the B2G process has crashed'},
./mozharness/mozilla/buildbot.py:        """ Generic sendchange, currently b2g- and unittest-specific.
./scripts/marionette.py:# TODO: we could remove emulator specific code after B2G ICS emulator buildbot

But it's just a couple comments and small bits of code.
Comment on attachment 8862163 [details]
Bug 1359988 - Remove mozharness configs for multi locale b2g builds;

https://reviewboard.mozilla.org/r/134148/#review137444
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2251f9ba4a65
Remove gaia scripts and configs from mozharness; r=mshal
https://hg.mozilla.org/integration/autoland/rev/b1223eadeb3e
Remove mozharness docs related to gaia; r=mshal
https://hg.mozilla.org/integration/autoland/rev/45200ddaa281
Remove references to gaia in mozharness; r=mshal
https://hg.mozilla.org/integration/autoland/rev/2cb79c5458b2
Remove mozharness configs for multi locale b2g builds; r=mshal
https://hg.mozilla.org/integration/autoland/rev/4a0497e64691
Remove spidermonkey b2g build script; r=mshal
https://hg.mozilla.org/integration/autoland/rev/87c44616d96c
Remove retrieve_b2g_device(); r=mshal
No longer blocks: 1369194
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.