Enable hardware VP9 decode on intel GPUs

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: kentuckyfriedtakahe, Assigned: jya)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

VP9 hardware decoding works well on Intel GPUs. We should enable by default.
(Assignee)

Updated

10 months ago
Assignee: nobody → jyavenard

Updated

10 months ago
See Also: → bug 1314458
Priority: -- → P3
Jean-Yves - what do I need to do to make this happen?
Flags: needinfo?(jyavenard)
Flags: needinfo?(ajones)
(Assignee)

Comment 2

9 months ago
Anthony, I'm not sure the intel is that much better really... There's definitely jitter compare to the software version
I described the issue in bug 1314458.
Very noticeable playing this scene: https://youtu.be/iNJdPyoqt8U?t=44

I have a patch ready, it may be simply that people using intel GPU don't care or just don't notice :)
Flags: needinfo?(jyavenard)
Comment hidden (mozreview-request)

Comment 4

9 months ago
mozreview-review
Comment on attachment 8873582 [details]
Bug 1360006: Whitelist VP9 decoder to intel GPU only.

https://reviewboard.mozilla.org/r/144962/#review149006

::: dom/media/platforms/wmf/DXVA2Manager.h:73
(Diff revision 1)
>    // need to take responsibility for creating a decoder and handle the related
>    // decoding operations by ourself.
>    virtual bool CreateDXVA2Decoder(const VideoInfo& aVideoInfo,
>                                    nsACString& aFailureReason) = 0;
>  
> +  virtual uint32_t GetVendorId() const { return 0; }

Might as well make this pure virtual since all subclasses implement it.
Attachment #8873582 - Flags: review?(matt.woodrow) → review+
Comment hidden (mozreview-request)

Comment 6

9 months ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77f2dd5563d2
Whitelist VP9 decoder to intel GPU only. r=mattwoodrow

Comment 7

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/77f2dd5563d2
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Flags: needinfo?(ajones)
You need to log in before you can comment on or make changes to this bug.