1360040 - Add test for restriction characters

Status: RESOLVED INVALID

(Firefox :: Address Bar, enhancement, P3)

Description

[Drew Willcoxon :adw]

See bug 1359278 comment 2:

(In reply to Marco Bonardo [::mak] from bug 1359278 comment #2)
> yeah looks like we don't test these. Not critical since it's a really edge
> case, so I'm fine to land this without a test for now.
> Please file a bug to add a test for manual setting a restriction char, and
> make it block bug 1315509, we'll look into it when (if) we'll finally make
> "?" special.

Comment 1

[Mathew Hodson]

I think this was filed under the wrong component. It should be under Firefox - Address Bar.

Comment 2

[Drew Willcoxon :adw]

In the past and even currently, restriction character handling is (mostly) in UnifiedComplete.js, which is part of Places, so that's why it's here.  But we have a bug to move UnifiedComplete to the browser front end (bug 1492226), and aside from that we're replacing UnifiedComplete with QuantumBar anyway, so you're right that this should probably be in the Address Bar component now.

There are probably many other UnifiedComplete open bugs in Places that may better belong in Address Bar now.  We briefly discussed what should happen with them, and we decided just to leave existing open bugs where they are, at least if/until we start focusing on them (see bug 1492226 comment 6).

Comment 3

[Marco Bonardo [:mak]]

we removed the pref allowing to change the reestriction chars so this should not be necessary anymore.