Closed Bug 1360056 Opened 7 years ago Closed 7 years ago

Support upgrading linux kernel on Ubuntu 16.04

Categories

(Infrastructure & Operations :: RelOps: Puppet, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dividehex, Assigned: dragrom)

References

Details

Attachments

(1 file, 1 obsolete file)

packages::kernel is silently skipped because there is no kernel version for 16.04 defined in the config.  We should set the var for 16.04 to the current version installed on 16.04 (and test it).  This will make things easier when we need to upgrade the kernel in the future.
Status: NEW → ASSIGNED
Comment on attachment 8863740 [details] [diff] [review]
puppetagain_Bug_1360056_Support_upgrading_linux_kernel_on_Ubuntu_16.patch

I tested this against my dhouse-133* vm in scl3, and it did not change anything (running 4.4.0-66-generic kernel already).
Attachment #8863740 - Flags: feedback+
Comment on attachment 8863740 [details] [diff] [review]
puppetagain_Bug_1360056_Support_upgrading_linux_kernel_on_Ubuntu_16.patch

Review of attachment 8863740 [details] [diff] [review]:
-----------------------------------------------------------------

There is a whole lot of unnecessary repetition here.  There is no need to separate this with a case as the code should be applicable to 12.04,14.04 and 16.04.  The only thing that really needs to be done is to set the kernel variable for 16.04 to '4.4.0.66.70' in moco-config.pp.  You may also need to re-initialize the custom kernel repo to include 16.04 in the Release.

As you can see, the variable being set in the config file is what allows the code to execute.  Therefore, your testing would not report any errors since the $current_kernel var [1] isn't set for 16.04.

[1] https://hg.mozilla.org/build/puppet/file/tip/manifests/moco-config.pp#l364

::: modules/packages/manifests/kernel.pp
@@ +81,5 @@
> +                    }
> +                    16.04: {
> +                        $current_kernel = '4.4.0-66'
> +                        if $lsbdistrelease == '16.04' and $architecture == 'i386' {
> +                            $suffix = '-generic-pae' }

Since '-generic-pae' doesn't apply to 14.04, I'm pretty sure doesn't apply here either
Attachment #8863740 - Flags: review?(jwatkins) → review-
Comment on attachment 8864438 [details] [diff] [review]
puppetagain_Bug_1360056_Support_upgrading_linux_kernel_on_Ubuntu_16.patch

Review of attachment 8864438 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good
Attachment #8864438 - Flags: review?(jwatkins) → review+
Comment on attachment 8864438 [details] [diff] [review]
puppetagain_Bug_1360056_Support_upgrading_linux_kernel_on_Ubuntu_16.patch

https://hg.mozilla.org/build/puppet/rev/9c0a0a28c3c68f931d3041e31ff0d06bff8d5f5a
Attachment #8864438 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1366828
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: