Closed
Bug 1360063
Opened 7 years ago
Closed 7 years ago
Move the parsing code for nsSVGViewBoxRect and SVGPreserveAspectRatio to those classes
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
4.97 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
6.85 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
I want to use nsSVGViewBoxRect and SVGPreserveAspectRatio in the LVG code (see bug 1353771), but the parsing for these two classes is in the wrong file/on the wrong class. I'd like to have the parsing code as a static method on these two classes instead.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8862242 -
Flags: review?(longsonr)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8862243 -
Flags: review?(longsonr)
Updated•7 years ago
|
status-firefox55:
--- → affected
status-firefox57:
affected → ---
Updated•7 years ago
|
Attachment #8862242 -
Flags: review?(longsonr) → review+
Updated•7 years ago
|
Attachment #8862243 -
Flags: review?(longsonr) → review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a4081536ff Expose the parsing and serializing code for SVGPreserveAspectRatio as methods. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3d47962249 Expose the parsing code for nsSVGViewBoxRect as a method. r=longsonr
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a0a4081536ff https://hg.mozilla.org/mozilla-central/rev/0c3d47962249
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•