Move the parsing code for nsSVGViewBoxRect and SVGPreserveAspectRatio to those classes

RESOLVED FIXED in Firefox 55

Status

()

Core
SVG
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

I want to use nsSVGViewBoxRect and SVGPreserveAspectRatio in the LVG code (see bug 1353771), but the parsing for these two classes is in the wrong file/on the wrong class. I'd like to have the parsing code as a static method on these two classes instead.
(Assignee)

Comment 1

6 months ago
Created attachment 8862242 [details] [diff] [review]
patch - Expose the parsing code for nsSVGViewBoxRect as a static method
Attachment #8862242 - Flags: review?(longsonr)
(Assignee)

Comment 2

6 months ago
Created attachment 8862243 [details] [diff] [review]
patch - Expose the parsing code for SVGPreserveAspectRatio as a static method
Attachment #8862243 - Flags: review?(longsonr)
status-firefox55: --- → affected
status-firefox57: affected → ---
Attachment #8862242 - Flags: review?(longsonr) → review+
Attachment #8862243 - Flags: review?(longsonr) → review+

Comment 3

6 months ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a4081536ff
Expose the parsing and serializing code for SVGPreserveAspectRatio as methods. r=longsonr
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c3d47962249
Expose the parsing code for nsSVGViewBoxRect as a method. r=longsonr

Comment 4

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a0a4081536ff
https://hg.mozilla.org/mozilla-central/rev/0c3d47962249
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.