1360152 - [Static Analysis][Coverity] /js/src/jsopcode.cpp: 1189 Execution cannot reach this statement: "js::ReportOutOfMemory(cx);".

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

The change in bug 1334278 changed the return value JS_smprintf to UniqueChars but didn't remove this OOM check:

*** CID 1405540:  Control flow issues  (DEADCODE)
/js/src/jsopcode.cpp: 1189 in ToDisassemblySource(JSContext *, JS::Handle<JS::Value>, JSAutoByteString *)()
1183                 return false;
1184             char* nbytes = QuoteString(&sprinter, v.toString(), '"');
1185             if (!nbytes)
1186                 return false;
1187             UniqueChars copy = JS_smprintf("%s", nbytes);
1188             if (!nbytes) {
>>>     CID 1405540:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "js::ReportOutOfMemory(cx);".
1189                 ReportOutOfMemory(cx);
1190                 return false;
1191             }
1192             bytes->initBytes(Move(copy));
1193             return true;
1194         }

If the OOM report is still need we should change it to |if (!copy)|

Comment 1

[Tom Tromey :tromey]

My bad.

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1360152 - null-check correct value in ToDisassemblySource;

Review commit: https://reviewboard.mozilla.org/r/134362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134362/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8862431 [details]
Bug 1360152 - null-check correct value in ToDisassemblySource;

https://reviewboard.mozilla.org/r/134362/#review137310

Doh!

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8862431 [details]
Bug 1360152 - null-check correct value in ToDisassemblySource;

https://reviewboard.mozilla.org/r/134362/#review137310

We may want to consider uplifting this if appropriate.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a2d5f57d453
null-check correct value in ToDisassemblySource; r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a2d5f57d453