1360192 - add a warning when a Rule's channel is changing

Status: RESOLVED WONTFIX

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

Changing the channel of a Rule should be a pretty rare operation. Doing so can often have big or unexpected impacts. We should add some level of warning in the UI, perhaps with some information or a link to something that talks about the potential implications of doing so, and things to consider before making the change.

Comment 1

[akriti verma]

I would like to work on this, but will need some more details for a clear understanding.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to akriti verma from comment #1)
> I would like to work on this, but will need some more details for a clear
> understanding.

Sure! I think it's best if you're able to run the local development environment before working on this. Can you try the instructions at http://mozilla-balrog.readthedocs.io/en/latest/contribute.html?  Once you're able to access http://localhost:8080/rules, you should be ready to go.

The idea is that when somebody clicks "Update" or "Schedule an Update" on a Rule, and then tries to change the "channel" value, a warning should be shown. This could take the form of an extra element in the modal dialog that pops up, or perhaps an alert when they click "Save Changes", or maybe something else.

Does that make sense?

Comment 3

[akriti verma]

Hi Ben ,i want to upload a patch , but when i am executing git commands the patch is getting uploaded on github. How can i upload it on Bugzilla?.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to akriti verma from comment #3)
> Hi Ben ,i want to upload a patch , but when i am executing git commands the
> patch is getting uploaded on github. How can i upload it on Bugzilla?.

Creating a pull request on Github is the right thing to do, if you can. Please send it to https://github.com/mozilla/balrog. If you have trouble with that, let me know.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/balrog/pull/444

Comment 6

[akriti verma]

Hi Ben,
Can you please tell me what implications should be mentioned in the warning message?

Comment 7

[Syed Ali]

I'm a student from coventry university studying an opensource module, I would like to be assigned this as my first bug! Could you please point me in the right direction of how to start

Comment 8

[[e-mail] (:bhearsum)]

Unassigning due to inactivity.

Comment 9

[[e-mail] (:bhearsum)]

Mass closure of old Balrog UI bugs. We've built a new UI in https://github.com/mozilla-frontend-infra/balrog-ui, and any issues which are still valid should be filed as Issues there.