Closed
Bug 1360201
Opened 7 years ago
Closed 7 years ago
emitDestructuringOpsArray emits "dupat 0" instead of "dup"
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
3.36 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
|dis(function(){}){}|
shows:
...
00018: dupat 0 # [] [][Symbol.iterator](...) [][Symbol.iterator](...)
...
We should emit a simple "dup" here.
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8862513 [details] [diff] [review] bug1360201.patch Review of attachment 8862513 [details] [diff] [review]: ----------------------------------------------------------------- Nice simplification.
Attachment #8862513 -
Flags: review?(shu) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4c84a238f17a36f58421ac7d4bbdbef2279eff6
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e05917890799 Emit |dup| instead of |dupat 0| when BytecodeEmitter::emitDupAt is called with zero. r=shu
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e05917890799
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•